From 0e69d07ef8c276508a920922b5f1a9b012c3a533 Mon Sep 17 00:00:00 2001 From: Christian Wendt Date: Wed, 1 Apr 2026 21:29:24 +0000 Subject: [PATCH 1/2] Final Standing field fallback --- espn_api/baseball/team.py | 2 +- espn_api/basketball/team.py | 2 +- espn_api/football/team.py | 2 +- espn_api/hockey/team.py | 2 +- espn_api/wbasketball/team.py | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/espn_api/baseball/team.py b/espn_api/baseball/team.py index f6ca13e79..5288d1867 100644 --- a/espn_api/baseball/team.py +++ b/espn_api/baseball/team.py @@ -18,7 +18,7 @@ def __init__(self, data, roster, schedule, year, **kwargs): self.ties = data['record']['overall']['ties'] self.logo_url = '' self.standing = data['playoffSeed'] - self.final_standing = data['rankFinal'] + self.final_standing = data.get('rankFinal') or data.get('rankCalculatedFinal') self.roster = [] self.schedule = [] if 'logo' in data: diff --git a/espn_api/basketball/team.py b/espn_api/basketball/team.py index e7edd9937..fe5d7d7ca 100644 --- a/espn_api/basketball/team.py +++ b/espn_api/basketball/team.py @@ -26,7 +26,7 @@ def __init__(self, data, roster, schedule, year, **kwargs): self.logo_url = '' self.stats = None self.standing = data['playoffSeed'] - self.final_standing = data['rankFinal'] + self.final_standing = data.get('rankFinal') or data.get('rankCalculatedFinal') self.roster: List[Player] = [] self.schedule = [] diff --git a/espn_api/football/team.py b/espn_api/football/team.py index b57d97168..b0c8c863e 100644 --- a/espn_api/football/team.py +++ b/espn_api/football/team.py @@ -26,7 +26,7 @@ def __init__(self, data, roster, schedule, year, **kwargs): self.streak_length = data['record']['overall']['streakLength'] self.streak_type = data['record']['overall']['streakType'] self.standing = data['playoffSeed'] - self.final_standing = data['rankFinal'] + self.final_standing = data.get('rankFinal') or data.get('rankCalculatedFinal') self.waiver_rank = data.get('waiverRank', 0) if 'logo' in data: self.logo_url = data['logo'] diff --git a/espn_api/hockey/team.py b/espn_api/hockey/team.py index 351d1a69c..dc0660ce4 100644 --- a/espn_api/hockey/team.py +++ b/espn_api/hockey/team.py @@ -21,7 +21,7 @@ def __init__(self, data, roster, schedule, year, **kwargs): self.logo_url = '' self.stats = None self.standing = data['playoffSeed'] - self.final_standing = data['rankFinal'] + self.final_standing = data.get('rankFinal') or data.get('rankCalculatedFinal') self.roster = [] self.schedule = [] self.year = year diff --git a/espn_api/wbasketball/team.py b/espn_api/wbasketball/team.py index 272a40f58..f47040aa4 100644 --- a/espn_api/wbasketball/team.py +++ b/espn_api/wbasketball/team.py @@ -19,7 +19,7 @@ def __init__(self, data, roster, schedule, year, **kwargs): self.logo_url = '' self.stats = None self.standing = data['playoffSeed'] - self.final_standing = data['rankFinal'] + self.final_standing = data.get('rankFinal') or data.get('rankCalculatedFinal') self.roster = [] self.schedule = [] From 144a2936cf86bd5cc0cdd1cd106742128e59561a Mon Sep 17 00:00:00 2001 From: Christian Wendt Date: Wed, 1 Apr 2026 21:37:29 +0000 Subject: [PATCH 2/2] add copilot extension to devcontainer --- .devcontainer/devcontainer.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 6891fe05f..cb268fb3c 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -35,7 +35,8 @@ "extensions": [ "ms-python.python", "ms-python.vscode-pylance", - "streetsidesoftware.code-spell-checker" + "streetsidesoftware.code-spell-checker", + "GitHub.copilot" ], // Use 'forwardPorts' to make a list of ports inside the container available locally.