one-dependency-per-line fixer assumes LF and will not work in a CRLF repository

[platinumazure]

The fixer for one-dependency-per-line uses LF unconditionally. In order to support CRLF repositories, an option should be added to support CRLF (e.g., { lineEnding: "\r\n" }).

Without this, people using auto-fix on this rule who also have the core ESLint linebreak-style rule set to Windows will generate errors in the latter rule when applying fixes from this rule.

Incidentally, I tried to get this sort of thing (duplicated rule configuration of CRLF and similar) handled in a more general "repository settings" section of ESLint configuration, but it got shot down, so we're stuck with the duplication.

[afahim]

@platinumazure let me know if you're not working on it, otherwise I can add in an option to take care of that case.

[platinumazure]

I'm not working on this anytime soon- please feel free to take this on if
you have time. Just let us know if you're going to take it on, or no longer
can, as your circumstances change; that way, everyone knows who's working
on it or if it is currently not being worked on. Thanks!
On Feb 12, 2016 3:03 PM, "Afnan Fahim" notifications@github.com wrote:

@platinumazure https://github.com/platinumazure let me know if you're
not working on it, I can add in an option to take care of that case.

—
Reply to this email directly or view it on GitHub
#58 (comment)
.

[afahim]

Cool. As regards to communication, would @cvisco be interested in starting a https://gitter.im/ for this repo? I might have questions to ask since I'm not a windows user myself.

[cvisco]

@afahim I'm not 100% convinced a gitter is worthwhile for such a small project. At least, it's not something I'd be able to personally monitor or partake in during most hours of the day. If something comes up that really does require realtime conversation, i'll certainly reevaluate. Until then, we can certainly answer questions here.

[afahim]

sounds good.

In case I get to work on this, I'll definitely update here. I'm a little busy these days.

[platinumazure]

This might be moot now with ESLint's multiple-pass auto-fix. If a user has both this rule and linebreak-style enabled, then the second lint/fix pass will fix any errors introduce by this rule's auto-fix logic.

[cvisco]

@platinumazure That may be true in some cases, but not all. I'd prefer to see this work reliably by itself :)

[platinumazure]

Actually I agree (I don't believe multiple pass auto-fix should be used to
cover up poor fixer design). But some folks are happy to get functionality
when they can and I felt duty-bound to bring it up.
On Jul 4, 2016 7:22 PM, "Casey Visco" notifications@github.com wrote:

@platinumazure https://github.com/platinumazure That may be true in
some cases, but not all. I'd prefer to see this work reliably by itself :)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#58 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AARWesLQyvzJGaRMo6E56UCqoYeKVvH3ks5qSaPggaJpZM4HHcf6
.