Improvement Summary
We should refactor the requestGameState() method of the game store to use the general helper makeSocketRequest() to make its request
Detailed Description
This would be more consistent with how requests are made throughout the rest of the game store. As of #1228, this is the approach used by requestSpectate() while still allowing the game view to re-authenticate the user if the request errors with a 401.
I attempted to refactor the requestGameState accordingly here but it failed CI.
We should revisit this to clean up this function and make it consistent with the game store, fixing whatever issue caused the 3 test failures as of the implementation in the above commit
Improvement Summary
We should refactor the
requestGameState()method of thegamestore to use the general helpermakeSocketRequest()to make its requestDetailed Description
This would be more consistent with how requests are made throughout the rest of the game store. As of #1228, this is the approach used by
requestSpectate()while still allowing the game view to re-authenticate the user if the request errors with a 401.I attempted to refactor the requestGameState accordingly here but it failed CI.
We should revisit this to clean up this function and make it consistent with the game store, fixing whatever issue caused the 3 test failures as of the implementation in the above commit