ovl: don't allow datadir only

JIRA: https://issues.redhat.com/browse/RHEL-83562

commit eb3a04a
Author: Miklos Szeredi <[email protected]>
Date:   Mon Feb 10 15:11:22 2025 +0100

    ovl: don't allow datadir only

    In theory overlayfs could support upper layer directly referring to a data
    layer, but there's no current use case for this.

    Originally, when data-only layers were introduced, this wasn't allowed,
    only introduced by the "datadir+" feature, but without actually handling
    this case, resulting in an Oops.

    Fix by disallowing datadir without lowerdir.

    Reported-by: Giuseppe Scrivano <[email protected]>
    Fixes: 24e16e3 ("ovl: add support for appending lowerdirs one by one")
    Cc: <[email protected]> # v6.7
    Reviewed-by: Amir Goldstein <[email protected]>
    Reviewed-by: Alexander Larsson <[email protected]>
    Reviewed-by: Christian Brauner <[email protected]>
    Signed-off-by: Miklos Szeredi <[email protected]>

Signed-off-by: Miklos Szeredi <[email protected]>

Originally, when data-only layers were introduced, this wasn't allowed,
only introduced by the "datadir+" feature, but without actually handling
this case, resulting in an Oops.

Fix by disallowing datadir without lowerdir.

Reported-by: Giuseppe Scrivano <[email protected]>
Fixes: 24e16e3 ("ovl: add support for appending lowerdirs one by one")
Cc: <[email protected]> # v6.7
Reviewed-by: Amir Goldstein <[email protected]>
Reviewed-by: Alexander Larsson <[email protected]>
Reviewed-by: Christian Brauner <[email protected]>
Signed-off-by: Miklos Szeredi <[email protected]>
(cherry picked from commit eb3a04a)

Author: Miklos Szeredi

fs/overlayfs/super.c

@@ -1126,6 +1126,11 @@ static struct ovl_entry *ovl_get_lowerstack(struct super_block *sb,
 		return ERR_PTR(-EINVAL);
 	}
 
+	if (ctx->nr == ctx->nr_data) {
+		pr_err("at least one non-data lowerdir is required\n");
+		return ERR_PTR(-EINVAL);
+	}
+
 	err = -EINVAL;
 	for (i = 0; i < ctx->nr; i++) {
 		l = &ctx->lower[i];