Skip to content

Commit 105419a

Browse files
authored
Remove @cypress/instrument-cra to resolve CVE-2017-16137 (#147)
We currently don't use the functionality, the github repo is archived, and hasn't been updated in 5 years. When we need the code coverage functionality, there are other and better ways of getting it.
1 parent 9981e2a commit 105419a

File tree

5 files changed

+0
-90
lines changed

5 files changed

+0
-90
lines changed

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ awx/ui/node_modules/
3636
awx/ui/coverage/
3737
awx/ui/build
3838
awx/ui/.env.local
39-
awx/ui/instrumented
4039
rsyslog.pid
4140
tools/docker-compose/ansible/awx_dump.sql
4241
tools/docker-compose/Dockerfile

Makefile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -454,9 +454,6 @@ ui-devel: awx/ui/node_modules
454454
cp -r awx/ui/build/static/media/* /var/lib/awx/public/static/media; \
455455
fi
456456

457-
ui-devel-instrumented: awx/ui/node_modules
458-
$(NPM_BIN) --prefix awx/ui --loglevel warn run start-instrumented
459-
460457
ui-devel-test: awx/ui/node_modules
461458
$(NPM_BIN) --prefix awx/ui --loglevel warn run start
462459

awx/ui/.eslintignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,4 @@ build
77
node_modules
88
dist
99
images
10-
instrumented
1110
*test*.js

awx/ui/package-lock.json

Lines changed: 0 additions & 82 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

awx/ui/package.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
"@babel/eslint-plugin": "^7.27.1",
4141
"@babel/plugin-syntax-jsx": "^7.27.1",
4242
"@babel/preset-react": "^7.27.1",
43-
"@cypress/instrument-cra": "^1.4.0",
4443
"@lingui/cli": "^4.14.0",
4544
"@lingui/conf": "^4.14.0",
4645
"@lingui/loader": "4.14.0",
@@ -73,11 +72,9 @@
7372
"scripts": {
7473
"prelint": "lingui compile",
7574
"prestart": "lingui compile",
76-
"prestart-instrumented": "lingui compile",
7775
"pretest": "lingui compile",
7876
"pretest-watch": "lingui compile",
7977
"start": "GENERATE_SOURCEMAP=false ESLINT_NO_DEV_ERRORS=true PORT=3001 HTTPS=true DANGEROUSLY_DISABLE_HOST_CHECK=true react-scripts start",
80-
"start-instrumented": "ESLINT_NO_DEV_ERRORS=true DEBUG=instrument-cra PORT=3001 HTTPS=true DANGEROUSLY_DISABLE_HOST_CHECK=true react-scripts -r @cypress/instrument-cra start",
8178
"build": "INLINE_RUNTIME_CHUNK=false react-scripts build",
8279
"test": "TZ='UTC' react-scripts test --watchAll=false",
8380
"test-screens": "TZ='UTC' react-scripts test screens --watchAll=false",

0 commit comments

Comments
 (0)