More codegen/rebind performance improvements

- Improved String building performance in AbstractMetaClass.hashString
- Cached the super class in JavaReflectionClass
- Optimized ClassScanner when processing reloadable classes

Author: JoshIsOnIt

errai-codegen/src/main/java/org/jboss/errai/codegen/meta/impl/AbstractMetaClass.java

@@ -761,24 +761,30 @@ public int hashContent() {
   }
 
   private String _hashString;
+  static final private String MetaClassName = MetaClass.class.getName();
+
   public String hashString() {
     if (_hashString == null) {
-      _hashString = MetaClass.class.getName().concat(":").concat(getFullyQualifiedName());
+      _hashString = MetaClassName + ":" + getFullyQualifiedName();
       if (getParameterizedType() != null) {
         _hashString += getParameterizedType().toString();
       }
     }
     return _hashString;
   }
 
+  private Integer _hashCode;
+
   @Override
   public int hashCode() {
-    return hashString().hashCode();
+    if (_hashCode != null)
+      return _hashCode;
+    return _hashCode = hashString().hashCode();
   }
 
   @Override
   public boolean equals(Object o) {
-    return o instanceof AbstractMetaClass && hashString().equals(((AbstractMetaClass) o).hashString());
+	  return o instanceof AbstractMetaClass && hashString().equals(((AbstractMetaClass) o).hashString());
   }
 
   @Override

errai-codegen/src/main/java/org/jboss/errai/codegen/meta/impl/java/JavaReflectionClass.java

@@ -366,14 +366,21 @@ public MetaClass[] getInterfaces() {
     return _interfacesCache = metaClassList.toArray(new MetaClass[metaClassList.size()]);
   }
 
+  private MetaClass _superClass;
+  
   @Override
   public MetaClass getSuperClass() {
+    if (_superClass != null)
+      return _superClass;
+
     if (getGenericSuperClass() != null) {
-      return parameterizedAs(getEnclosedMetaObject().getSuperclass(), typeParametersOf(getGenericSuperClass().getTypeParameters()));
+      _superClass = parameterizedAs(getEnclosedMetaObject().getSuperclass(), typeParametersOf(getGenericSuperClass()
+              .getTypeParameters()));
     }
     else {
-      return newInstance(getEnclosedMetaObject().getSuperclass());
+      _superClass = newInstance(getEnclosedMetaObject().getSuperclass());
     }
+    return _superClass;
   }
 
   @Override

errai-config/src/main/java/org/jboss/errai/config/util/ClassScanner.java

@@ -12,6 +12,7 @@
 import java.util.Set;
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.CopyOnWriteArrayList;
+import java.util.concurrent.CopyOnWriteArraySet;
 import java.util.concurrent.atomic.AtomicLong;
 import java.util.regex.Pattern;
 
@@ -39,7 +40,7 @@ public static class CacheHolder implements CacheStore {
     final Map<MetaClass, Collection<MetaClass>> subtypesCache = new ConcurrentHashMap<MetaClass, Collection<MetaClass>>();
     final Collection<MetaClass> reloadableClasses =  new CopyOnWriteArrayList<MetaClass>();
     final Collection<String> reloadableClassNames =  new CopyOnWriteArrayList<String>();
-    final Collection<String> reloadablePackages =  new CopyOnWriteArrayList<String>();
+    final Set<String> reloadablePackages =  new CopyOnWriteArraySet<String>();
 
     @Override
     public void clear() {
@@ -293,12 +294,22 @@ private static Collection<MetaClass> getAllReloadableCachedClasses(final Generat
 
     final Collection<MetaClass> classes = new ArrayList<MetaClass>();
     final Collection<String> classNames = new ArrayList<String>();
+    
     for (MetaClass clazz : MetaClassFactory.getAllCachedClasses()) {
-      for (String reloadablePackage : cache.reloadablePackages) {
-        final String fqcn = clazz.getFullyQualifiedName();
-        if (fqcn.startsWith(reloadablePackage)) {
-          classes.add(clazz);
-          classNames.add(fqcn);
+      final String fqcn = clazz.getFullyQualifiedName();
+
+      if (cache.reloadablePackages.contains(clazz.getPackageName())) {
+        classes.add(clazz);
+        classNames.add(fqcn);
+      }
+      else {
+        for (String reloadablePackage : cache.reloadablePackages) {
+          if (fqcn.startsWith(reloadablePackage)) {
+            classes.add(clazz);
+            classNames.add(fqcn);
+            cache.reloadablePackages.add(clazz.getPackageName());
+            break;
+          }
         }
       }
     }