Object#crystal_type_id returns different value for virtual type in interpreter #14967
Description
In the following compiled code, upcasting a Bar to a Foo doesn't change the value of Object#crystal_type_id, because a type ID read is involved:
class Foo
end
class Bar < Foo
end
Foo.crystal_instance_type_id # => 177
Bar.crystal_instance_type_id # => 176
Foo.new.crystal_type_id # => 177
Bar.new.crystal_type_id # => 176
(Bar.new.as(Foo)).crystal_type_id # => 176
Bar.new.as(Foo).as(Int32*).value # => 176The same code produces a different result when interpreted:
Foo.crystal_instance_type_id # => 188
Bar.crystal_instance_type_id # => 189
Foo.new.crystal_type_id # => 188
Bar.new.crystal_type_id # => 189
(Bar.new.as(Foo)).crystal_type_id # => 190 # should be 189
Bar.new.as(Foo).as(Int32*).value # => 189The code responsible for this is:
crystal/src/compiler/crystal/interpreter/primitives.cr
Lines 118 to 128 in a798ae6
owner is a VirtualType, and 190 is the type ID for Foo+ instances. This however should never happen, because the point of crystal_type_id is to obtain the type ID corresponding to the run-time type.