Skip to content

Commit 276a30d

Browse files
CI: Run multi-threading test job with execution context (#16339)
[Execution contexts (RFC 0002)](crystal-lang/rfcs#2) are nearing maturity (#15342) and until now we aren't even running CI with this configuration. It only runs `std_spec` but that should be fine. I wouldn't expect much benefit from running compiler specs as well. Dropping the dedicated job for `-Dpreview_mt` only without `-Dexecution_context` because we're not expecting to continue supporting the multi-threading preview with the old scheduler model. Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
1 parent 46315e7 commit 276a30d

File tree

1 file changed

+25
-2
lines changed

1 file changed

+25
-2
lines changed

.github/workflows/linux.yml

Lines changed: 25 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ jobs:
5252
run: bin/ci build
5353
env: ${{ matrix.env }}
5454

55-
x86_64-gnu-test-preview_mt:
55+
x86_64-gnu-test-execution-context-parallel:
5656
env:
5757
ARCH: x86_64
5858
ARCH_CMD: linux64
@@ -73,7 +73,30 @@ jobs:
7373
run: bin/ci with_build_env 'make crystal'
7474

7575
- name: Test
76-
run: bin/ci with_build_env 'CRYSTAL_WORKERS=4 make std_spec threads=1 FLAGS="-D preview_mt"'
76+
run: bin/ci with_build_env 'CRYSTAL_WORKERS=4 make std_spec threads=1 FLAGS="-Dexecution_context -Dpreview_mt"'
77+
78+
x86_64-gnu-test-execution-context-concurrent:
79+
env:
80+
ARCH: x86_64
81+
ARCH_CMD: linux64
82+
runs-on: ubuntu-latest
83+
steps:
84+
- name: Download Crystal source
85+
uses: actions/checkout@v6
86+
with:
87+
persist-credentials: false
88+
89+
- name: Prepare System
90+
run: bin/ci prepare_system
91+
92+
- name: Prepare Build
93+
run: bin/ci prepare_build
94+
95+
- name: Make Crystal
96+
run: bin/ci with_build_env 'make crystal'
97+
98+
- name: Test
99+
run: bin/ci with_build_env 'CRYSTAL_WORKERS=1 make std_spec threads=1 FLAGS="-Dexecution_context -Dpreview_mt"'
77100

78101
check_format:
79102
env:

0 commit comments

Comments
 (0)