fix: add authorisation address check in the blocklist (#1924)

* add missing authorisation address

* add changelog

* remove extra line

Author: thomas-nguy

CHANGELOG.md

@@ -7,6 +7,7 @@
 * [#1903](https://github.com/crypto-org-chain/cronos/pull/1903) Feat: check authorization list in e2ee.
 * [#1922](https://github.com/crypto-org-chain/cronos/pull/1922) Feat: check destination address in the blocklist
 * [#1904](https://github.com/crypto-org-chain/cronos/pull/1904) Test: add eip-7702 tests
+* [#1924](https://github.com/crypto-org-chain/cronos/pull/1924) Fix: check authorisation address in the blocklist
 
 ### Bug fixes
 

app/block_address.go

@@ -62,6 +62,10 @@ func (bad BlockAddressesDecorator) AnteHandle(ctx sdk.Context, tx sdk.Tx, simula
 								return ctx, fmt.Errorf("signer is blocked: %s", addr.String())
 							}
 						}
+						// check the target address
+						if _, ok := bad.blockedMap[sdk.AccAddress(auth.Address.Bytes()).String()]; ok {
+							return ctx, fmt.Errorf("authorisation address is blocked: %s", sdk.AccAddress(auth.Address.Bytes()).String())
+						}
 					}
 				}
 			}

app/proposal.go

@@ -198,6 +198,14 @@ func (h *ProposalHandler) ValidateTransaction(tx sdk.Tx, txBz []byte) error {
 							return fmt.Errorf("signer is blocked: %s", addr.String())
 						}
 					}
+					// check the target address
+					encoded, err := h.addressCodec.BytesToString(auth.Address.Bytes())
+					if err != nil {
+						return fmt.Errorf("invalid bech32 address: %s, err: %w", auth.Address, err)
+					}
+					if _, ok := h.blocklist[encoded]; ok {
+						return fmt.Errorf("authorisation address is blocked: %s", encoded)
+					}
 				}
 			}
 		}