Skip to content

Commit 81fc4e0

Browse files
author
yihuang
authored
Problem: rocksdb nix expression hard code the major version (#1198)
- handle the major version dynamically. Signed-off-by: yihuang <[email protected]>
1 parent a31a35d commit 81fc4e0

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

nix/rocksdb.nix

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ stdenv.mkDerivation rec {
8181
mkdir -p $tools/bin
8282
cp tools/{ldb,sst_dump}${stdenv.hostPlatform.extensions.executable} $tools/bin/
8383
'' + lib.optionalString stdenv.isDarwin ''
84-
ls -1 $tools/bin/* | xargs -I{} ${stdenv.cc.bintools.targetPrefix}install_name_tool -change "@rpath/librocksdb.8.dylib" $out/lib/librocksdb.dylib {}
84+
ls -1 $tools/bin/* | xargs -I{} ${stdenv.cc.bintools.targetPrefix}install_name_tool -change "@rpath/librocksdb.${lib.versions.major version}.dylib" $out/lib/librocksdb.dylib {}
8585
'' + lib.optionalString (stdenv.isLinux && enableShared) ''
8686
ls -1 $tools/bin/* | xargs -I{} patchelf --set-rpath $out/lib:${stdenv.cc.cc.lib}/lib {}
8787
'';
@@ -94,7 +94,7 @@ stdenv.mkDerivation rec {
9494
fi
9595
'' + lib.optionalString stdenv.isDarwin ''
9696
${stdenv.cc.targetPrefix}install_name_tool -change "@rpath/libsnappy.1.dylib" "${snappy}/lib/libsnappy.1.dylib" $out/lib/librocksdb.dylib
97-
${stdenv.cc.targetPrefix}install_name_tool -change "@rpath/librocksdb.8.dylib" "$out/lib/librocksdb.8.dylib" $out/lib/librocksdb.dylib
97+
${stdenv.cc.targetPrefix}install_name_tool -change "@rpath/librocksdb.${lib.versions.major version}.dylib" "$out/lib/librocksdb.${lib.versions.major version}.dylib" $out/lib/librocksdb.dylib
9898
'';
9999

100100
meta = with lib; {

0 commit comments

Comments
 (0)