fix(presign): remove baseUri from reports and jfr-datasource, send full presigned URLs #1078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependent
needs-triage
andrewazores
added
fix
safe-to-test
and removed
needs-triage
Member
Author
|
/build_test |
|
Workflow started at 9/30/2025, 4:31:26 PM. View Actions Run. |
|
No GraphQL schema changes detected. |
|
No OpenAPI schema changes detected. |
|
CI build and push: All tests pass ✅ |
andrewazores
force-pushed
the
external-s3-smoketest
branch
from
bfdb2bd to
2a371d1
Compare
Member
Author
|
/build_test |
|
Workflow started at 9/30/2025, 5:25:17 PM. View Actions Run. |
|
No OpenAPI schema changes detected. |
|
No GraphQL schema changes detected. |
|
CI build and push: All tests pass ✅ |
andrewazores
force-pushed
the
external-s3-smoketest
branch
from
2a371d1 to
3284406
Compare
andrewazores
force-pushed
the
external-s3-smoketest
branch
from
3284406 to
155cfc9
Compare
Member
Author
|
/build_test |
|
Workflow started at 10/9/2025, 3:11:13 PM. View Actions Run. |
|
No OpenAPI schema changes detected. |
|
No GraphQL schema changes detected. |
|
CI build and push: All tests pass ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainSee cryostatio/cryostat-operator#1146 (comment)
Depends on cryostatio/jfr-datasource#427
Depends on cryostatio/cryostat-reports#405
Description of the change:
This change allows an environment variable to be configured so that...
Motivation for the change:
This change is helpful because users may want to...
How to manually test: