fixup for immutable Map returned by S3 SDK client for object metadata

Author: andrewazores

src/main/java/io/cryostat/events/S3TemplateService.java

@@ -23,6 +23,7 @@
 import java.nio.file.Path;
 import java.text.ParseException;
 import java.util.ArrayList;
+import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 import java.util.Objects;
@@ -249,7 +250,7 @@ private Template convertObject(S3Object object)
                 break;
             case METADATA:
                 var headReq = HeadObjectRequest.builder().bucket(bucket).key(object.key()).build();
-                var meta = storage.headObject(headReq).metadata();
+                var meta = new HashMap<>(storage.headObject(headReq).metadata());
                 label = Objects.requireNonNull(meta.get(META_KEY_NAME));
                 description = Objects.requireNonNull(meta.get(META_KEY_DESCRIPTION));
                 provider = Objects.requireNonNull(meta.get(META_KEY_PROVIDER));

src/main/java/io/cryostat/recordings/RecordingHelper.java

@@ -1039,7 +1039,7 @@ public Optional<Metadata> getArchivedRecordingMetadata(String storageKey) {
                     if (!resp.hasMetadata()) {
                         return Optional.empty();
                     }
-                    return Optional.of(new Metadata(resp.metadata()));
+                    return Optional.of(new Metadata(new HashMap<>(resp.metadata())));
                 case BUCKET:
                     return metadataService.get().read(storageKey);
                 default: