do not include BASIC_AUTH_KEY in generated storage secret

Author: andrewazores

internal/controllers/secrets.go

@@ -19,8 +19,6 @@ import (
 	"errors"
 	"fmt"
 
-	b64 "encoding/base64"
-
 	"github.com/cryostatio/cryostat-operator/internal/controllers/constants"
 	"github.com/cryostatio/cryostat-operator/internal/controllers/model"
 	corev1 "k8s.io/api/core/v1"
@@ -123,9 +121,6 @@ const storageSecretAccessKey = "ACCESS_KEY"
 // storageSecretUserKey indexes the password within the Cryostat storage Secret
 const storageSecretPassKey = "SECRET_KEY"
 
-// storageSecretBasicAuthKey indexes the Basic auth credentials (Base64-encoded) within the Cryostat storage Secret
-const storageSecretBasicAuthKey = "BASIC_AUTH_KEY"
-
 func (r *Reconciler) reconcileStorageSecret(ctx context.Context, cr *model.CryostatInstance) error {
 	secret := &corev1.Secret{
 		ObjectMeta: metav1.ObjectMeta{
@@ -145,7 +140,6 @@ func (r *Reconciler) reconcileStorageSecret(ctx context.Context, cr *model.Cryos
 			passwd := r.GenPasswd(32)
 			secret.StringData[storageSecretAccessKey] = accessKey
 			secret.StringData[storageSecretPassKey] = passwd
-			secret.StringData[storageSecretBasicAuthKey] = b64.StdEncoding.EncodeToString(fmt.Appendf(nil, "%s:%s", accessKey, passwd))
 		}
 		return nil
 	})

internal/test/resources.go

@@ -1805,9 +1805,8 @@ func (r *TestResources) NewStorageSecret() *corev1.Secret {
 			Namespace: r.Namespace,
 		},
 		Data: map[string][]byte{
-			"SECRET_KEY":     []byte("object_storage"),
-			"ACCESS_KEY":     []byte("cryostat"),
-			"BASIC_AUTH_KEY": []byte("Y3J5b3N0YXQ6b2JqZWN0X3N0b3JhZ2U="),
+			"SECRET_KEY": []byte("object_storage"),
+			"ACCESS_KEY": []byte("cryostat"),
 		},
 	}
 }