Merge pull request #2235 from saiharsha-plivo/fix/ecs-service

fix(ecs): issue with empty network configuration parameter

Author: MisterMX

examples/ecs/service.yaml

@@ -37,3 +37,41 @@ spec:
       name: example
   providerConfigRef:
     name: example
+---
+apiVersion: ecs.aws.crossplane.io/v1alpha1
+kind: Service
+metadata:
+  name: nginx-test-ecs
+  annotations:
+    task-definition-network-mode: awsvpc
+spec:
+  forProvider:
+    cluster: arn:aws:ecs:us-east-1:123456789:cluster/crossplane-ecs-controller-test
+    launchType: EC2
+    region: us-east-1
+    schedulingStrategy: DAEMON
+    networkConfiguration:
+      awsvpcConfiguration:
+        assignPublicIP: DISABLED
+        subnets: 
+        - subnet-06338caec7dcf
+        - subnet-02a8df89fdafa
+    taskDefinition: arn:aws:ecs:us-east-1:123456789:task-definition/nginx:3
+  providerConfigRef:
+    name: providerconfig-aws
+---
+apiVersion: ecs.aws.crossplane.io/v1alpha1
+kind: Service
+metadata:
+  name: filebeat-test
+  annotations:
+    task-definition-network-mode: host
+spec:
+  forProvider:
+    cluster: arn:aws:ecs:us-east-1:123456789:cluster/crossplane-ecs-controller-test
+    launchType: EC2
+    region: us-east-1
+    schedulingStrategy: DAEMON
+    taskDefinition: arn:aws:ecs:us-east-1:123456789:task-definition/pratyush-filebeat:1
+  providerConfigRef:
+    name: providerconfig-aws

pkg/controller/ecs/service/setup.go

@@ -537,7 +537,7 @@ func generateNetworkConfiguration(cr *svcapitypes.Service) *svcsdk.NetworkConfig
 	networkConfiguration := &svcsdk.NetworkConfiguration{}
 
 	if cr.Spec.ForProvider.NetworkConfiguration == nil {
-		return networkConfiguration
+		return nil
 	}
 
 	if cr.Spec.ForProvider.NetworkConfiguration.AWSvpcConfiguration != nil {