Skip to content

group: make 'result-as-the-first-parameter' from EventEmitters available #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

group: make 'result-as-the-first-parameter' from EventEmitters available #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions lib/step.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ function Step() {
};

// Generates a callback generator for grouped results
next.group = function () {
next.group = function (resFirst) {
var localCallback = next.parallel();
var counter = 0;
var pending = 0;
Expand All @@ -107,12 +107,14 @@ function Step() {
pending++;
return function () {
pending--;
// Compress the error from any result to the first argument
if (arguments[0]) {
if (resFirst) {
result[index] = arguments[0];
} else if (arguments[0]) {
// Compress the error from any result to the first argument
error = arguments[0];
// Send the other results as arguments
result[index] = arguments[1];
}
// Send the other results as arguments
result[index] = arguments[1];
if (!lock) { check(); }
};
};
Expand Down