You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Dec 20, 2024. It is now read-only.
This PR edits a comment that was outdated and led to some confusion
about whether the code can properly handle multiple txs from the same
environment in the same block (the answer is that it indeed handles them
properly).
Identical PR in the solver rewards repo
[here](cowprotocol/solver-rewards#402).
Copy file name to clipboardExpand all lines: src/sql/orderbook/barn_batch_rewards.sql
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -87,7 +87,7 @@ order_surplus AS (
87
87
JOIN settlement_scores ss -- contains block_deadline
88
88
ONs.auction_id=ss.auction_id
89
89
JOIN trades t -- contains traded amounts
90
-
ONs.block_number=t.block_number--log_index cannot be checked, does not work correctly with multiple auctions on the same block
90
+
ONs.block_number=t.block_number--given the join that follows with the order execution table, this works even when multiple txs appear in the same block
91
91
JOIN order_data od -- contains tokens and limit amounts
Copy file name to clipboardExpand all lines: src/sql/orderbook/prod_batch_rewards.sql
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -87,7 +87,7 @@ order_surplus AS (
87
87
JOIN settlement_scores ss -- contains block_deadline
88
88
ONs.auction_id=ss.auction_id
89
89
JOIN trades t -- contains traded amounts
90
-
ONs.block_number=t.block_number--log_index cannot be checked, does not work correctly with multiple auctions on the same block
90
+
ONs.block_number=t.block_number--given the join that follows with the order execution table, this works even when multiple txs appear in the same block
91
91
JOIN order_data od -- contains tokens and limit amounts
0 commit comments