refactor: use the built-in max/min to simplify the code #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR(Pull Request) Overview
In Go 1.21, the standard library includes built-in max/min function, which can greatly simplify the code.
Changes
Related Issue
Please reference the Issue number this PR addresses: #123
Description of Changes
Describe the key changes or parts of the code that have been modified.
Testing Method
Explain how to test the changes step by step: 1. Run ‘…’ 2. Check ‘…’
Additional Information
If there is any additional information relevant to this PR, please include it here.