Skip to content

Commit 47a9c97

Browse files
committed
Fix missing error return checks in certgen
1 parent 81635c0 commit 47a9c97

File tree

1 file changed

+18
-4
lines changed

1 file changed

+18
-4
lines changed

certgen.go

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,20 +57,34 @@ func GenerateCert(dst string) error {
5757
if err != nil {
5858
return fmt.Errorf("Could not open %s for writing: %s", dst, err)
5959
}
60-
pem.Encode(certOut, &pem.Block{Type: "CERTIFICATE", Bytes: derBytes})
61-
certOut.Close()
60+
err = pem.Encode(certOut, &pem.Block{Type: "CERTIFICATE", Bytes: derBytes})
61+
if err != nil {
62+
return err
63+
}
64+
65+
err = certOut.Close()
66+
if err != nil {
67+
return err
68+
}
6269

6370
keyOut, err := os.OpenFile(dst, os.O_WRONLY|os.O_APPEND, 0600)
6471
if err != nil {
6572
return fmt.Errorf("Could not open %s for writing: %s", dst, err)
6673
}
67-
pem.Encode(
74+
err = pem.Encode(
6875
keyOut,
6976
&pem.Block{
7077
Type: "RSA PRIVATE KEY",
7178
Bytes: x509.MarshalPKCS1PrivateKey(priv),
7279
},
7380
)
74-
keyOut.Close()
81+
if err != nil {
82+
return err
83+
}
84+
85+
err = keyOut.Close()
86+
if err != nil {
87+
return err
88+
}
7589
return nil
7690
}

0 commit comments

Comments
 (0)