Skip to content

Commit ca336f1

Browse files
larssbmrueg
authored andcommitted
Defalt val. of hpa.metrics to the correct type
This sets the hpa.metrics key to its correct default value. Which is an array and not a dict. Having it as a dict. gives issues as seen in #79. Which I hope to solve with this PR. See: https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/horizontal-pod-autoscaler-v2/#HorizontalPodAutoscalerSpec for the official ref. docs on HPA and the `metrics` key type specifically. Thank you. Signed-off-by: Lars Bengtsson <[email protected]> Signed-off-by: Lars Bengtsson <[email protected]>
1 parent 4a9f0dd commit ca336f1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

charts/coredns/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ hpa:
240240
enabled: false
241241
minReplicas: 1
242242
maxReplicas: 2
243-
metrics: {}
243+
metrics: []
244244

245245
## Configue a cluster-proportional-autoscaler for coredns
246246
# See https://github.com/kubernetes-incubator/cluster-proportional-autoscaler

0 commit comments

Comments
 (0)