Skip to content

Commit 6a9cb21

Browse files
committed
fix: improve default readiness probe config for shutdown
On shutdown coredns will wait what is configured for lameduck and continue handling connections. At the same time it will fail readiness probes. In order to give readiness checks a chance to remove the instance from the service we need to lower the failure threshold and the interval. This is to avoid failing DNS requests in a busy cluster when coredns is being scaled down. Signed-off-by: Heiko Voigt <[email protected]>
1 parent 558c99d commit 6a9cb21

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

charts/coredns/Chart.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
apiVersion: v2
22
name: coredns
3-
version: 1.39.1
3+
version: 1.39.2
44
appVersion: 1.12.0
55
home: https://coredns.io
66
icon: https://coredns.io/images/CoreDNS_Colour_Horizontal.png
@@ -20,4 +20,4 @@ type: application
2020
annotations:
2121
artifacthub.io/changes: |
2222
- kind: fixed
23-
description: align imagePullSecrets in Deployment and ServiceAccount
23+
description: improve default readiness probe config for shutdown

charts/coredns/values.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ servers:
118118
# Serves a /health endpoint on :8080, required for livenessProbe
119119
- name: health
120120
configBlock: |-
121-
lameduck 5s
121+
lameduck 10s
122122
# Serves a /ready endpoint on :8181, required for readinessProbe
123123
- name: ready
124124
# Required to query kubernetes API for data
@@ -174,9 +174,9 @@ livenessProbe:
174174
readinessProbe:
175175
enabled: true
176176
initialDelaySeconds: 30
177-
periodSeconds: 10
177+
periodSeconds: 5
178178
timeoutSeconds: 5
179-
failureThreshold: 5
179+
failureThreshold: 1
180180
successThreshold: 1
181181

182182
# expects input structure as per specification https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.11/#affinity-v1-core

0 commit comments

Comments
 (0)