Skip to content

Commit 1921572

Browse files
authored
Merge pull request #206 from dglushenok/master
fix supported schemes: add https:// to tcp-only scheme list
2 parents ed11181 + 59dd655 commit 1921572

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

charts/coredns/Chart.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
apiVersion: v2
22
name: coredns
3-
version: 1.39.2
3+
version: 1.40.0
44
appVersion: 1.12.0
55
home: https://coredns.io
66
icon: https://coredns.io/images/CoreDNS_Colour_Horizontal.png
@@ -19,5 +19,5 @@ maintainers:
1919
type: application
2020
annotations:
2121
artifacthub.io/changes: |
22-
- kind: fixed
23-
description: improve default readiness probe config for shutdown
22+
- kind: added
23+
description: add https:// to tcp-only scheme list

charts/coredns/templates/_helpers.tpl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ Generate the list of ports automatically from the server definitions
8383
Look at each of the zones and check which protocol they serve
8484
At the moment the following are supported by CoreDNS:
8585
UDP: dns://
86-
TCP: tls://, grpc://
86+
TCP: tls://, grpc://, https://
8787
*/}}
8888
{{- range .zones -}}
8989
{{- if has (default "" .scheme) (list "dns://") -}}
@@ -94,7 +94,7 @@ Generate the list of ports automatically from the server definitions
9494
{{- $innerdict := set $innerdict "isudp" true -}}
9595
{{- end -}}
9696

97-
{{- if has (default "" .scheme) (list "tls://" "grpc://") -}}
97+
{{- if has (default "" .scheme) (list "tls://" "grpc://" "https://") -}}
9898
{{- $innerdict := set $innerdict "istcp" true -}}
9999
{{- end -}}
100100
{{- end -}}
@@ -155,7 +155,7 @@ Generate the list of ports automatically from the server definitions
155155
Look at each of the zones and check which protocol they serve
156156
At the moment the following are supported by CoreDNS:
157157
UDP: dns://
158-
TCP: tls://, grpc://
158+
TCP: tls://, grpc://, https://
159159
*/}}
160160
{{- range .zones -}}
161161
{{- if has (default "" .scheme) (list "dns://") -}}
@@ -166,7 +166,7 @@ Generate the list of ports automatically from the server definitions
166166
{{- $innerdict := set $innerdict "isudp" true -}}
167167
{{- end -}}
168168

169-
{{- if has (default "" .scheme) (list "tls://" "grpc://") -}}
169+
{{- if has (default "" .scheme) (list "tls://" "grpc://" "https://") -}}
170170
{{- $innerdict := set $innerdict "istcp" true -}}
171171
{{- end -}}
172172
{{- end -}}

0 commit comments

Comments
 (0)