Improve MFG workflow - #1005

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Remove Test HRM from the extras menu as it's a hardware test that belongs
in the tests menu, not in extras. Keep the relaunch mechanism in place for
future extras items.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Add a new mfg_test_result module that keeps test results (pass/fail
and a uint32_t value) in a static RAM array, replacing the legacy
MFG_INFO_RECORDS_TEST_RESULTS mechanism.

Each test app can call mfg_test_result_report() to record its outcome.
The test menu queries results via mfg_test_result_get() to show
check/X icons for all tests. Tests that haven't reported yet show no
icon.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Report pass/fail and buttons_pressed bitmask via the new
mfg_test_result API so the test menu shows [P]/[F] status.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Instead of cycling patterns endlessly, show a confirmation dialog
after all patterns have been displayed. Up button records PASS,
Down/Back records FAIL via the mfg_test_result API, then exits.

Removes the legacy MFG_INFO_RECORDS_TEST_RESULTS code path.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Give users 10s to touch all zones. If all touched before timeout,
show PASS for 3s; otherwise show FAIL for 3s. Report result via
mfg_test_result API and exit.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Track the selected menu index when launching a test. On return,
automatically select the next entry so the operator can quickly
proceed through the test list. First open defaults to the first
entry.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

After cycling through all backlight colors, show a confirmation dialog
asking if the backlight is OK and report the result.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Replace the 3-orientation test (flat/left/front) with a single
variation-based approach matching the magnetometer test: track min/max
on all axes during a 5-second window while the user rotates the device,
pass if all axes vary by at least 500 mG. Report result automatically.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Display pass/fail for 3 seconds after the test completes, report the
result, and automatically close the app instead of waiting for user
input.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Display pass/fail for 3 seconds after the test completes, report the
result via mfg_test_result_report, and automatically close the app.
Clean up unused includes.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Add an app that encodes all test results into a QR code for scanning.
Each test is encoded as a short tag with pass/fail status and optional
value (e.g. BTN:P,F; DSP:P; ALS:P,14900). Iterates over all test IDs
so new tests are automatically included.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Only show RGB color test patterns on platforms with color backlight.
Non-color platforms show only the white step before prompting the
result dialog. Also remove the PLATFORM_OBELIX guard from the test
menu so backlight test is available on all platforms.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

…hen finished

Add a select (center) button handler to both charge and discharge tests
so that the operator can exit by pressing the center key once the test
has completed (pass or fail).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

When a test completes (pass or fail), automatically launch the next test
instead of returning to the menu. When the user presses BACK to exit a
test without completing it, the menu now selects the current test rather
than advancing to the next one.

Add mfg_test_result_was_reported() to detect whether a test result was
recorded since the last check, allowing the menu to distinguish test
completion from user back-out. Refactor the test entries table to file
scope with get_info function pointers, replacing per-test select
callbacks with a single generic one.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Previously back button was ignored while the charge test was running.
Allow exiting at any time; result is only reported if the test had
already finished.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Only auto-advance to the next test when the previous test passed.
On failure, return to the menu with the failed test selected so the
operator can immediately retry it.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Simplify the charge test to only check that charging starts and
temperature is within range:

- Wait for watch to be plugged
- Once plugged, wait up to 5s for charging to start
- If charging and temperature in range, PASS; otherwise FAIL
- Auto-close on unplug after result

Remove battery percentage/fast charge logic, long countdown timer,
and button-based result reporting.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Move the aging test entry from the extras menu to the main menu,
placed just before the reset option for easier access.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Remove the BT Device Name entry from the main manufacturing menu
along with its application code, as it is no longer needed.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Display the serial number and battery percentage in the Device Info
menu item subtitle (e.g. "XXXXXX - 90%"), updating live via the
battery state service.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Remove the extras menu entirely and move its only remaining item
(Load PRF) to the main menu as the last option.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Rework BLE Adv app to display a QR code with the device MAC address
and the MAC as text below it. Remove pass/fail confirmation dialog
and test result reporting. Move from test menu to main menu (after
Aging) and remove MfgTestId_Adv.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Program Color now reports the WatchInfoColor enum as the test result
value. QR results renders it as the color short name (e.g. CLR:P,BK20).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Remove the standalone discharge test, as the aging test now covers
discharge monitoring with component cycling.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Split the test menu into two modes: semi-finished and finished.
Each test entry has a mode bitmask controlling its availability.
Currently, Program Color is only available in finished mode; all
other tests are available in both modes.

The main menu now has "Semi-finished Tests" and "Finished Tests"
entries. QR results skips tests not available in the active mode.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Semi-finished and finished test modes were sharing a single results
array, so results from one mode would leak into the other. Use a 2D
array indexed by mode so each mode has its own independent results.
Also reset the menu selection when entering a mode so auto-advance
state doesn't carry across modes.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>

Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>