Improve code quality with linting fixes and cleanup (#4)

* Improve code quality with linting fixes and cleanup

- Added rustfmt.toml and .clippy.toml configuration files
- Fixed redundant closures by using direct function references
- Marked unused variables with underscores
- Added #[allow(dead_code)] attributes to public API functions
- Simplified return statements and improved code patterns
- Fixed error handling in async functions
- All tests passing with no Clippy warnings in main code

* Add GitHub Actions workflow with linting and testing steps

- Added a CI workflow that runs on push to main and pull requests
- Included separate jobs for build/test and linting
- Added code formatting check with rustfmt
- Added Clippy linting with warnings treated as errors
- Configured caching to speed up CI runs

---------

Co-authored-by: Don Johnson <[email protected]>

Author: copyleftdev

.clippy.toml

@@ -0,0 +1,4 @@
+# Allow code that would be automatically fixed by rustfmt
+cognitive-complexity-threshold = 25
+too-many-arguments-threshold = 7
+disallowed-methods = []

.github/workflows/rust-ci.yml

@@ -0,0 +1,79 @@
+name: Rust CI
+
+on:
+  push:
+    branches: [ main ]
+  pull_request:
+    branches: [ main ]
+
+env:
+  CARGO_TERM_COLOR: always
+
+jobs:
+  build_and_test:
+    name: Build and Test
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      
+      - name: Install Rust
+        uses: actions-rs/toolchain@v1
+        with:
+          profile: minimal
+          toolchain: stable
+          override: true
+          components: rustfmt, clippy
+      
+      - name: Cache dependencies
+        uses: actions/cache@v3
+        with:
+          path: |
+            ~/.cargo/registry
+            ~/.cargo/git
+            target
+          key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
+          
+      - name: Build
+        uses: actions-rs/cargo@v1
+        with:
+          command: build
+          
+      - name: Run tests
+        uses: actions-rs/cargo@v1
+        with:
+          command: test
+          
+  linting:
+    name: Lint Code
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      
+      - name: Install Rust
+        uses: actions-rs/toolchain@v1
+        with:
+          profile: minimal
+          toolchain: stable
+          override: true
+          components: rustfmt, clippy
+          
+      - name: Cache dependencies
+        uses: actions/cache@v3
+        with:
+          path: |
+            ~/.cargo/registry
+            ~/.cargo/git
+            target
+          key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
+          
+      - name: Check code formatting
+        uses: actions-rs/cargo@v1
+        with:
+          command: fmt
+          args: --all -- --check
+          
+      - name: Clippy
+        uses: actions-rs/cargo@v1
+        with:
+          command: clippy
+          args: -- -D warnings

rustfmt.toml

@@ -0,0 +1,13 @@
+max_width = 100
+hard_tabs = false
+tab_spaces = 4
+newline_style = "Auto"
+use_small_heuristics = "Default"
+reorder_imports = true
+reorder_modules = true
+remove_nested_parens = true
+edition = "2021"
+merge_derives = true
+use_field_init_shorthand = true
+use_try_shorthand = true
+format_strings = true

src/config.rs

@@ -1,25 +1,24 @@
 use anyhow::Result;
 use std::path::Path;
-use tracing;
 
 /// Configuration for scanning
 #[derive(Debug, Clone)]
 pub struct ScanConfig {
     /// Path to input file with domains, one per line
     pub input_file: String,
-    
+
     /// Path to rules file
     pub rules_file: String,
-    
+
     /// Number of concurrent scanners
     pub concurrency: usize,
-    
+
     /// Verbosity level: 0=error, 1=warn, 2=info, 3=debug, 4=trace
     pub verbosity: u8,
-    
+
     /// Whether to use distributed mode
     pub distributed: bool,
-    
+
     /// Path to output file
     pub output_file: Option<String>,
 
@@ -71,6 +70,7 @@ impl Default for ScanConfig {
 
 impl ScanConfig {
     /// Create a new scan configuration with default values
+    #[allow(dead_code)]
     pub fn new(input_file: String, rules_file: String) -> Self {
         Self {
             input_file,
@@ -89,35 +89,32 @@ impl ScanConfig {
             verbose: false,
         }
     }
-    
+
     /// Validate the configuration
     pub fn validate(&self) -> Result<()> {
         // Check if input file exists
         if !Path::new(&self.input_file).exists() {
             anyhow::bail!("input file does not exist: {}", self.input_file);
         }
-        
+
         // Check if rules file exists
         if !Path::new(&self.rules_file).exists() {
             anyhow::bail!("Rules file does not exist: {}", self.rules_file);
         }
-        
+
         // Check concurrency value
         if self.concurrency == 0 {
             anyhow::bail!("Invalid concurrency value: must be greater than 0");
         }
-        
+
         Ok(())
     }
-    
+
     /// Log the configuration
     pub fn log_config(&self) {
         // Use event-based tracing which is more reliably captured by test infrastructure
-        tracing::event!(
-            tracing::Level::INFO,
-            message = "Configuration:"
-        );
-        
+        tracing::event!(tracing::Level::INFO, message = "Configuration:");
+
         // Log each configuration value as a separate event for better test capturing
         tracing::event!(
             tracing::Level::INFO,
@@ -189,7 +186,7 @@ impl ScanConfig {
             verbose = self.verbose,
             message = format!("  verbose: {}", self.verbose)
         );
-        
+
         tracing::event!(
             tracing::Level::DEBUG,
             message = "Configuration validated successfully"