Replace manual change tracking with track-changes library #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* copilot.el (track-changes): New requirement. (copilot--lsp-pos): New helper function. (copilot--generate-doc): Use it. (copilot--on-doc-change): Remove. (copilot--track-changes-id): New buffer-local variable. (copilot--lsp-range-end-from-oldtext): New helper function. (copilot--track-changes-signal): New function to fetch and forward buffer changes. (copilot--mode-setup): Remove old before-change-functions and after-change-functions hooks, register with track-changes instead. (copilot--mode-teardown): Remove old cleanup code, unregister from track-changes. * Eask: Add track-changes version 1.4 as a dependency.
ultronozm
force-pushed
the
track-changes
branch
from
313dcad to
f6d7399
Compare
bbatsov
approved these changes
Oct 28, 2025
Collaborator
bbatsov
left a comment
bbatsov
left a comment
There was a problem hiding this comment.
Nice improvement! I hadn't noticed the track-changes library so far, but it looks quite handy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #430.
(copilot--generate-doc): Use it.
(copilot--on-doc-change): Remove.
(copilot--track-changes-id): New buffer-local variable. (copilot--lsp-range-end-from-oldtext): New helper function. (copilot--track-changes-signal): New function to fetch and forward buffer changes.
(copilot--mode-setup): Remove old before-change-functions and after-change-functions hooks, register with track-changes instead. (copilot--mode-teardown): Remove old cleanup code, unregister from track-changes.