Skip to content

Update getExecutingScript to fix issue where "cnvr" labels are hardcoded into code #17

@jeffreytgilbert

Description

@jeffreytgilbert

https://github.com/conversant/ad-libs.js/blob/master/lib/dom/getExecutingScript.js

getExecutingScript has default flags set to options specific to an implementation in an external script, which is bad practice and could result in odd errors in other scripts using this functionality. Please remove this default label data and if that functionality is required, move those behaviors to params. It should not be required behavior. This is used in multiple places already and only one i know of requires this behavior.

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions