Skip to content

Commit b5c86a6

Browse files
committed
fix: remove non-used function and add nosec comments
1 parent a636ff8 commit b5c86a6

4 files changed

Lines changed: 3 additions & 54 deletions

File tree

‎pkg/yum/gpg_key.go‎

Lines changed: 0 additions & 35 deletions
This file was deleted.

‎pkg/yum/gpg_key_test.go‎

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,13 @@
11
package yum
22

33
import (
4-
"context"
54
_ "embed"
65
"net/http"
7-
"testing"
8-
9-
"github.com/stretchr/testify/assert"
106
)
117

128
//go:embed "mocks/gpgkey.pub"
139
var gpgKey []byte
1410

15-
func TestFetchGPGKey(t *testing.T) {
16-
s := server()
17-
defer s.Close()
18-
19-
c := s.Client()
20-
21-
gpg, code, err := FetchGPGKey(context.Background(), s.URL+"/gpgkey.pub", c)
22-
assert.NotEmpty(t, gpg)
23-
assert.Equal(t, 200, code)
24-
assert.Nil(t, err)
25-
}
26-
2711
func serveGPGKey(w http.ResponseWriter, r *http.Request) {
2812
w.Header().Add("Content-Type", "application/octet-stream")
2913
body := gpgKey

‎pkg/yum/module_stream.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ func (r *Repository) ModuleMDs(ctx context.Context) ([]ModuleMD, int, error) {
8989
return nil, 0, fmt.Errorf("error creating request: %w", err)
9090
}
9191

92-
if resp, err = r.settings.Client.Do(req); err != nil {
92+
if resp, err = r.settings.Client.Do(req); err != nil /* #nosec G704 */ {
9393
return nil, erroredStatusCode(resp), fmt.Errorf("GET error for file %v: %w", modulesURL, err)
9494
}
9595
defer resp.Body.Close()

‎pkg/yum/repository.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ func (r *Repository) Repomd(ctx context.Context) (*Repomd, int, error) {
166166
return nil, 0, fmt.Errorf("error creating request: %w", err)
167167
}
168168

169-
if resp, err = r.settings.Client.Do(req); err != nil {
169+
if resp, err = r.settings.Client.Do(req); err != nil /* #nosec G704 */ {
170170
return nil, erroredStatusCode(resp), fmt.Errorf("GET error for file %v: %w", repomdURL, err)
171171
}
172172
defer resp.Body.Close()
@@ -214,7 +214,7 @@ func (r *Repository) Comps(ctx context.Context) (*Comps, int, error) {
214214
return nil, 0, fmt.Errorf("error creating request: %w", err)
215215
}
216216

217-
if resp, err = r.settings.Client.Do(req); err != nil {
217+
if resp, err = r.settings.Client.Do(req); err != nil /* #nosec G704 */ {
218218
return nil, erroredStatusCode(resp), fmt.Errorf("GET error for file %v: %w", compsURL, err)
219219
}
220220

0 commit comments

Comments
 (0)