Skip to content

Conversation

@yashsingh74
Copy link

The PR fixes the following changes-

  • Allow default run args -it to be overridden by specifying DOCKER_RUN_ARGS.
  • Introduce GO_IMAGE and GO_VERSION to allow the compiliation docker image to be specified.
  • Add logic to handle the case where a non alpine golang image is used so that the script no longer blindly attempts to apk install bash and tar. Scripts checks for presence of both commands.
  • Avoid using dos2unix, use sed

@yashsingh74 yashsingh74 force-pushed the yashsingh/update-release branch from 2169ca8 to 2206c44 Compare May 28, 2024 10:16
@yashsingh74
Copy link
Author

cc: @squeed @danwinship

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant