libcni: Fix error handling in GCNetworkList #1165
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return actual error from GetCachedAttachments instead of nil to properly propagate errors and avoid silent failures when getting cached attachments fails during garbage collection. Signed-off-by: Enrique Llorente <[email protected]>
qinqon
force-pushed
the
fix-gc-network-list-error-handling
branch
from
f09423c to
2b26a54
Compare
squeed
reviewed
Jul 21, 2025
| cachedAttachments, err := c.GetCachedAttachments("") | ||
| if err != nil { | ||
| return nil | ||
| return err |
Member
There was a problem hiding this comment.
should we return err, or skip straight to the GC call?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes error handling in the GCNetworkList function where it was returning nil instead of the actual error from GetCachedAttachments, causing silent failures.
Changes
Context
The issue was located around lines 772-775 in libcni/api.go where the error handling incorrectly returned nil instead of the error when GetCachedAttachments failed.
Testing