[CI] Tigron breakout: golangci v2 and cleanups #4041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update to golangci v2 - remove dependency on go-imports-reviser (in favor of golangci provided gci) - remove useless tasks - remove hack make-license Signed-off-by: apostasie <[email protected]>
apostasie
commented
Mar 27, 2025
| ########################## | ||
| # High-level tasks definitions | ||
| ########################## | ||
| lint: lint-go-all lint-imports lint-yaml lint-shell lint-commits lint-headers lint-mod lint-licenses-all |
Contributor
Author
There was a problem hiding this comment.
imports (lint and fix) are now provided by golangci-lint with gci.
Separate tasks and module are no longer necessary.
apostasie
commented
Mar 27, 2025
| ########################## | ||
| lint-go: | ||
| $(call title, $@) | ||
| $(call title, $@: $(GOOS)) |
Contributor
Author
There was a problem hiding this comment.
Clarifies output.
apostasie
commented
Mar 27, 2025
| $(call title, $@) | ||
| $(call title, $@: $(GOOS)) | ||
| @cd $(MAKEFILE_DIR) \ | ||
| && ./hack/make-lint-licenses.sh |
Contributor
Author
There was a problem hiding this comment.
Separate hack is no longer necessary.
apostasie
force-pushed
the
ci-tigron-break-1
branch
from
7ee1c4a to
1a15067
Compare
apostasie
force-pushed
the
ci-tigron-break-1
branch
from
1a15067 to
97d5f43
Compare
AkihiroSuda
reviewed
Mar 27, 2025
AkihiroSuda
reviewed
Mar 27, 2025
- satisfy updated golangci-lint - simplify code - simplify func signatures - enhance documentation a bit Signed-off-by: apostasie <[email protected]>
apostasie
force-pushed
the
ci-tigron-break-1
branch
from
97d5f43 to
a92e93c
Compare
Contributor
Author
|
CI panic logged in #4043 |
apostasie
changed the title
This was referenced Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades golangci-lint to v2, cleans-up the Makefile a bit, and a few cosmetic cleanups of the codebase in preparation for more drastic changes.