[Bug]: Error shown in category search (upload photo) when no input is provided

[zihanpan]

Summary

When uploading a photo, the step 3 is performing a category search. At the moment I get in that page, an error message ' no categories found' is incorrectly displayed even when the search input field is empty. Then the editText will not accept any input. This behavior is unexpected because no search should trigger an error message when no input is provided. The error message should only appear when a valid search term is entered and no results are found.

Steps to reproduce

1. Click the '+' in the right bottom of main page.
2. Choose the second button which means select an existing photo
3. Choose a photo
4. Finish the step1 and step2
5. Enter the page of step 3, the error message will show immediately and disappear. Then no matter what you type in, the edit text wont accept it and won't search.

Expected behaviour

The system should not display an error message if user has just enter that page.

Actual behaviour

The error message show immediately and disappear. Then no matter what you type in, the edit text wont accept it and won't search.

Device name

Android Emulators

Android version

Android 14

Commons app version

master

Device logs

2024-10-19 02:11:18.611 8054-8054 AutofillManager fr.free.nrw.commons.beta D view not autofillable - not passing ime action check

Screen-shots

No response

Would you like to work on the issue?

Yes

[zihanpan]

Screen_recording_20241019_025434_compressed.mp4

I found this bug when I work on #4895. I think it is because showError of onAttachView did not check if the term is not blank.
So if possible, could I work on this issue?