Batch upload: Images swap in gallery

[nicolas-raoul]

Steps to reproduce:

1. Upload Pic1 and Pic2 together
2. After you choose the license, you are back the gallery and the pictures are being uploaded
3. Problem: The gallery thumbnail of Pic1 and Pic2 swap as they progress. I would expect each thumbnail to stay where it is.

Commons app version:

2.9.0
Screen-shots:

[albendz]

My guess for this issue is that the timestamps are the same on those uploaded images. The results are sorted by timestamp (https://github.com/commons-app/apps-android-commons/blob/master/app/src/main/java/fr/free/nrw/commons/contributions/ContributionDao.java#L36) and if they were too close they might show up in a different order each time.

[nicolas-raoul]

It is important to show the currently upload at the top to inform the user, indeed.
Maybe adding titles before each image category (for instance "Media being uploaded", "Failed uploads", "Successful uploads")? "Successful uploads" should be hidden when it is the only title.

[ashishkumar468]

@nicolas-raoul are you still facing this issue on latest commits?

[nicolas-raoul]

The pictures still swap in the order that their upload finish, but at least they do not swap while uploading.

[ashishkumar468]

@nicolas-raoul Just to confirm the order of contributions after the upload is based on uploadFInishedTimestamp instead of uploadStartTimestamp, is this what you meant?