Merge pull request #56 from collecthor/fix/fix-multiple-choice-parser

SamMousa · web-flow · commit f86e4b202585 · 2022-12-30T09:04:45.000+01:00
fix: use the correct way to generate the name of multiple choice questions
diff --git a/src/Parsers/MultipleChoiceQuestionParser.php b/src/Parsers/MultipleChoiceQuestionParser.php
@@ -9,6 +9,7 @@
 use Collecthor\SurveyjsParser\SurveyConfiguration;
 use Collecthor\SurveyjsParser\Values\StringValueOption;
 use Collecthor\SurveyjsParser\Variables\MultipleChoiceVariable;
+use function implode;
 
 final class MultipleChoiceQuestionParser implements ElementParserInterface
 {
@@ -18,7 +19,7 @@ public function parse(ElementParserInterface $root, array $questionConfig, Surve
     {
         $dataPath = [...$dataPrefix, $this->extractValueName($questionConfig)];
 
-        $name = $this->extractName($questionConfig);
+        $name = implode(".", $dataPath);
 
         $titles = $this->extractTitles($questionConfig);
 

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@`
`9`	`9`	`use Collecthor\SurveyjsParser\SurveyConfiguration;`
`10`	`10`	`use Collecthor\SurveyjsParser\Values\StringValueOption;`
`11`	`11`	`use Collecthor\SurveyjsParser\Variables\MultipleChoiceVariable;`
	`12`	`+use function implode;`
`12`	`13`
`13`	`14`	`final class MultipleChoiceQuestionParser implements ElementParserInterface`
`14`	`15`	`{`
`@@ -18,7 +19,7 @@ public function parse(ElementParserInterface $root, array $questionConfig, Surve`
`18`	`19`	`{`
`19`	`20`	`$dataPath = [...$dataPrefix, $this->extractValueName($questionConfig)];`
`20`	`21`
`21`		`- $name = $this->extractName($questionConfig);`
	`22`	`+ $name = implode(".", $dataPath);`
`22`	`23`
`23`	`24`	`$titles = $this->extractTitles($questionConfig);`
`24`	`25`