Merge pull request #52 from collecthor/fix-boolean-locale-fallback

fix: boolean variable displayvalue fallback to default locale

Author: SamMousa

composer.json

@@ -35,7 +35,7 @@
     },
     "require": {
         "php": ">= 8.1",
-        "collecthor/data-interfaces": ">= 5.2"
+        "collecthor/data-interfaces": "5.2.*"
     },
     "config": {
         "allow-plugins": {

src/Variables/BooleanVariable.php

@@ -65,9 +65,9 @@ public function getDisplayValue(RecordInterface $record, ?string $locale = 'defa
             return new StringValue((string) $result->getRawValue());
         } else {
             if ($result->getRawValue()) {
-                return new StringValue($this->trueLabels[$locale]);
+                return new StringValue($this->trueLabels[$locale] ?? $this->trueLabels['default']);
             } else {
-                return new StringValue($this->falseLabels[$locale]);
+                return new StringValue($this->falseLabels[$locale] ?? $this->falseLabels['default']);
             }
         }
     }

tests/Variables/BooleanVariableTest.php

@@ -141,4 +141,25 @@ public function testNullValue(): void
 
         self::assertInstanceOf(MissingBooleanValue::class, $value);
     }
+
+    public function testFallbackToDefaultLocale(): void
+    {
+        $subject = new BooleanVariable(
+            "test",
+            [],
+            [
+                "default" => "true",
+                "nl" => "waar",
+            ],
+            [
+                "default" => "false",
+                "nl" => "onwaar",
+            ],
+            ['path']
+        );
+
+        $record = new ArrayRecord(['path' => true], 1, new \DateTime(), new \DateTime());
+        self::assertSame("true", $subject->getDisplayValue($record)->getRawValue());
+        self::assertSame("true", $subject->getDisplayValue($record, 'fakeLocale')->getRawValue());
+    }
 }