Skip to content

Fix timezone-dependent test failures in timestamp assertions #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elpete merged 2 commits into from
Jan 29, 2026
Merged

Fix timezone-dependent test failures in timestamp assertions #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85f87ee
Initial plan
Copilot Jan 28, 2026
7bc0f21
Convert timestamp string literals to createDateTime() in migrations
Copilot Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/resources/database/migrations/2020_08_11_102347_create_countries_table.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@ component {
{
"id": "02B84D66-0AA0-F7FB-1F71AFC954843861",
"name": "United States",
"created_date": "2017-07-28 02:07:00",
"modified_date": "2017-07-28 02:07:00"
"created_date": createDateTime( 2017, 07, 28, 02, 07, 00 ),
"modified_date": createDateTime( 2017, 07, 28, 02, 07, 00 )
},
{
"id": "02BA2DB0-EB1E-3F85-5F283AB5E45608C6",
"name": "Argentina",
"created_date": "2017-07-29 03:07:00",
"modified_date": "2017-07-29 03:07:00"
"created_date": createDateTime( 2017, 07, 29, 03, 07, 00 ),
"modified_date": createDateTime( 2017, 07, 29, 03, 07, 00 )
}
] );
}
Expand Down
20 changes: 10 additions & 10 deletions tests/resources/database/migrations/2020_08_11_102531_create_users_table.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ component {
"password": "5F4DCC3B5AA765D61D8327DEB882CF99",
"country_id": "02B84D66-0AA0-F7FB-1F71AFC954843861",
"team_id": 1,
"created_date": "2017-07-28 02:06:36",
"modified_date": "2017-07-28 02:06:36",
"created_date": createDateTime( 2017, 07, 28, 02, 06, 36 ),
"modified_date": createDateTime( 2017, 07, 28, 02, 06, 36 ),
"type": "admin",
"externalId": "1234",
"streetOne": "123 Elm Street",
Expand All @@ -50,8 +50,8 @@ component {
"password": "5F4DCC3B5AA765D61D8327DEB882CF99",
"country_id": "02B84D66-0AA0-F7FB-1F71AFC954843861",
"team_id": 1,
"created_date": "2017-07-28 02:07:16",
"modified_date": "2017-07-28 02:07:16",
"created_date": createDateTime( 2017, 07, 28, 02, 07, 16 ),
"modified_date": createDateTime( 2017, 07, 28, 02, 07, 16 ),
"type": "limited",
"externalId": "6789",
"streetOne": "123 Elm Street",
Expand All @@ -69,8 +69,8 @@ component {
"password": "5F4DCC3B5AA765D61D8327DEB882CF99",
"country_id": { "value": "", "null": true },
"team_id": 1,
"created_date": "2017-07-28 02:08:16",
"modified_date": "2017-07-28 02:08:16",
"created_date": createDateTime( 2017, 07, 28, 02, 08, 16 ),
"modified_date": createDateTime( 2017, 07, 28, 02, 08, 16 ),
"type": "limited",
"externalId": "5555",
"streetOne": "123 Elm Street",
Expand All @@ -88,8 +88,8 @@ component {
"password": "5F4DCC3B5AA765D61D8327DEB882CF99",
"country_id": "02BA2DB0-EB1E-3F85-5F283AB5E45608C6",
"team_id": 2,
"created_date": "2019-06-15 12:29:36",
"modified_date": "2019-06-15 12:29:36",
"created_date": createDateTime( 2019, 06, 15, 12, 29, 36 ),
"modified_date": createDateTime( 2019, 06, 15, 12, 29, 36 ),
"type": "admin",
"externalId": "1234",
"streetOne": "123 Elm Street",
Expand All @@ -107,8 +107,8 @@ component {
"password": "5F4DCC3B5AA765D61D8327DEB882CF99",
"country_id": "02BA2DB0-EB1E-3F85-5F283AB5E45608C6",
"team_id": 3,
"created_date": "2020-01-14 12:29:36",
"modified_date": "2020-06-22 12:29:36",
"created_date": createDateTime( 2020, 01, 14, 12, 29, 36 ),
"modified_date": createDateTime( 2020, 06, 22, 12, 29, 36 ),
"type": "limited",
"externalId": { "value": "", "null": true },
"streetOne": "1725 Slough Avenue",
Expand Down
20 changes: 10 additions & 10 deletions tests/resources/database/migrations/2020_08_11_102557_create_my_posts_table.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,33 +15,33 @@ component {
"post_pk": 1245,
"user_id": 1,
"body": "My awesome post body",
"created_date": "2017-07-28 02:07:00",
"modified_date": "2017-07-28 02:07:00",
"published_date": "2017-07-28 02:07:00"
"created_date": createDateTime( 2017, 07, 28, 02, 07, 00 ),
"modified_date": createDateTime( 2017, 07, 28, 02, 07, 00 ),
"published_date": createDateTime( 2017, 07, 28, 02, 07, 00 )
},
{
"post_pk": 523526,
"user_id": 1,
"body": "My second awesome post body",
"created_date": "2017-07-28 02:07:36",
"modified_date": "2017-07-28 02:07:36",
"created_date": createDateTime( 2017, 07, 28, 02, 07, 36 ),
"modified_date": createDateTime( 2017, 07, 28, 02, 07, 36 ),
"published_date": { "value": "", "null": true }
},
{
"post_pk": 7777,
"user_id": { "value": "", "null": true },
"body": "My post with no author",
"created_date": "2017-07-30 07:00:22",
"modified_date": "2017-07-30 07:00:22",
"created_date": createDateTime( 2017, 07, 30, 07, 00, 22 ),
"modified_date": createDateTime( 2017, 07, 30, 07, 00, 22 ),
"published_date": { "value": "", "null": true }
},
{
"post_pk": 321,
"user_id": 4,
"body": "My post with a different author",
"created_date": "2017-08-28 14:22:22",
"modified_date": "2017-08-28 14:22:22",
"published_date": "2017-08-28 14:22:22"
"created_date": createDateTime( 2017, 08, 28, 14, 22, 22 ),
"modified_date": createDateTime( 2017, 08, 28, 14, 22, 22 ),
"published_date": createDateTime( 2017, 08, 28, 14, 22, 22 )
}
] );
}
Expand Down
8 changes: 4 additions & 4 deletions tests/resources/database/migrations/2020_08_11_102605_create_videos_table.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,16 @@ component {
"url": "https://www.youtube.com/watch?v=JDzIypmP0eo",
"title": "Building KiteTail with Adam Wathan",
"description": "Awesome live coding experience",
"created_date": "2017-06-28 02:07:36",
"modified_date": "2017-06-30 12:17:24"
"created_date": createDateTime( 2017, 06, 28, 02, 07, 36 ),
"modified_date": createDateTime( 2017, 06, 30, 12, 17, 24 )
},
{
"id": 1245,
"url": "https://www.youtube.com/watch?v=BgAlQuqzl8o",
"title": "Cello Wars",
"description": "Star Wars Cello Parody",
"created_date": "2017-07-02 04:14:22",
"modified_date": "2017-07-02 04:14:22"
"created_date": createDateTime( 2017, 07, 02, 04, 14, 22 ),
"modified_date": createDateTime( 2017, 07, 02, 04, 14, 22 )
}
] );
}
Expand Down
12 changes: 6 additions & 6 deletions tests/resources/database/migrations/2020_08_11_102612_create_comments_table.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ component {
"commentable_type": "Post",
"designation": "public",
"user_id": 1,
"created_date": "2017-07-02 04:14:22",
"modified_date": "2017-07-02 04:14:22"
"created_date": createDateTime( 2017, 07, 02, 04, 14, 22 ),
"modified_date": createDateTime( 2017, 07, 02, 04, 14, 22 )
},
{
"id": 2,
Expand All @@ -30,8 +30,8 @@ component {
"commentable_type": "Post",
"designation": "public",
"user_id": 2,
"created_date": "2017-07-04 04:14:22",
"modified_date": "2017-07-04 04:14:22"
"created_date": createDateTime( 2017, 07, 04, 04, 14, 22 ),
"modified_date": createDateTime( 2017, 07, 04, 04, 14, 22 )
},
{
"id": 3,
Expand All @@ -40,8 +40,8 @@ component {
"commentable_type": "Video",
"designation": "public",
"user_id": 1,
"created_date": "2017-07-02 04:14:22",
"modified_date": "2017-07-02 04:14:22"
"created_date": createDateTime( 2017, 07, 02, 04, 14, 22 ),
"modified_date": createDateTime( 2017, 07, 02, 04, 14, 22 )
}
] );
}
Expand Down
4 changes: 2 additions & 2 deletions tests/resources/database/migrations/2020_08_11_102613_create_internal_comments_table.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ component {
"commentable_type": "Post",
"designation": "internal",
"user_id": 1,
"created_date": "2017-07-02 04:14:22",
"modified_date": "2017-07-02 04:14:22"
"created_date": createDateTime( 2017, 07, 02, 04, 14, 22 ),
"modified_date": createDateTime( 2017, 07, 02, 04, 14, 22 )
}
] );

Expand Down
2 changes: 1 addition & 1 deletion tests/resources/database/migrations/2020_08_11_102636_create_links_table.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ component {
{
"link_id": 1,
"link_url": "http://example.com/some-link",
"created_date": "2017-07-28 02:07:00"
"created_date": createDateTime( 2017, 07, 28, 02, 07, 00 )
}
] );
}
Expand Down
4 changes: 2 additions & 2 deletions tests/resources/database/migrations/2020_08_11_102640_create_referrals_table.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ component {
{
"id": 1,
"type": "external",
"created_date": "2017-07-28 02:07:00",
"modified_date": "2017-07-28 02:07:00"
"created_date": createDateTime( 2017, 07, 28, 02, 07, 00 ),
"modified_date": createDateTime( 2017, 07, 28, 02, 07, 00 )
}
] );
}
Expand Down
8 changes: 4 additions & 4 deletions tests/resources/database/migrations/2020_08_11_102649_create_songs_table.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@ component {
"id": 1,
"title": "Ode to Joy",
"download_url": "https://open.spotify.com/track/4Nd5HJn4EExnLmHtClk4QV",
"created_date": "2017-07-28 02:07:00",
"modified_date": "2017-07-28 02:07:00"
"created_date": createDateTime( 2017, 07, 28, 02, 07, 00 ),
"modified_date": createDateTime( 2017, 07, 28, 02, 07, 00 )
},
{
"id": 2,
"title": "Open Arms",
"download_url": "https://open.spotify.com/track/1m2INxep6LfNa25OEg5jZl",
"created_date": "2017-07-28 02:07:00",
"modified_date": "2017-07-28 02:07:00"
"created_date": createDateTime( 2017, 07, 28, 02, 07, 00 ),
"modified_date": createDateTime( 2017, 07, 28, 02, 07, 00 )
}
] );
}
Expand Down
4 changes: 2 additions & 2 deletions tests/resources/database/migrations/2020_08_11_102650_create_jingles_table.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ component {
"id": 3,
"title": "I Wish I Was an Oscar Mayer Weiner",
"download_url": "https://open.spotify.com/track/2wyg2ln6p4gEkdqM2mueLn?si=kWBpdUz1TLymdmTro-xjtw",
"created_date": "2017-07-28 02:07:00",
"modified_date": "2017-07-28 02:07:00"
"created_date": createDateTime( 2017, 07, 28, 02, 07, 00 ),
"modified_date": createDateTime( 2017, 07, 28, 02, 07, 00 )
}
] );

Expand Down
4 changes: 2 additions & 2 deletions tests/resources/database/migrations/2024_06_13_134500_create_picture_comments_table.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ component {
"commentable_type": "Post",
"designation": "picture",
"user_id": 1,
"created_date": "2024-06-13 13:14:22",
"modified_date": "2024-06-13 13:14:22",
"created_date": createDateTime( 2024, 06, 13, 13, 14, 22 ),
"modified_date": createDateTime( 2024, 06, 13, 13, 14, 22 ),
"sentimentAnalysis" : '{ "analyzed": true, "magnitude": 0.8, "score": 0.6 }'
}
] );
Expand Down