Skip to content

Commit 5107d24

Browse files
fduwjjpytorchmergebot
authored andcommitted
[c10d][Logging] Remove args and kwargs from c10d logging (pytorch#140169)
This PR is trying to reland pytorch#139804 We now don't want to log args and kwargs directly because if they contain tensor or tensor subclass it would take lots of time in conversion to string or even not supported. Pull Request resolved: pytorch#140169 Approved by: https://github.com/wz337, https://github.com/kwen2501
1 parent 052b67e commit 5107d24

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

test/distributed/test_c10d_logger.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -118,16 +118,14 @@ def test_exception_logger(self) -> None:
118118
re.search("({.+})", captured.output[0]).group(0).replace("'", '"')
119119
)
120120

121-
self.assertEqual(len(error_msg_dict), 10)
121+
self.assertEqual(len(error_msg_dict), 9)
122122

123123
self.assertIn("pg_name", error_msg_dict.keys())
124124
self.assertEqual("None", error_msg_dict["pg_name"])
125125

126126
self.assertIn("func_name", error_msg_dict.keys())
127127
self.assertEqual("broadcast", error_msg_dict["func_name"])
128128

129-
self.assertIn("args", error_msg_dict.keys())
130-
131129
self.assertIn("backend", error_msg_dict.keys())
132130
self.assertEqual("nccl", error_msg_dict["backend"])
133131

@@ -162,16 +160,14 @@ def test_time_logger(self) -> None:
162160
msg_dict = json.loads(
163161
re.search("({.+})", captured.output[0]).group(0).replace("'", '"')
164162
)
165-
self.assertEqual(len(msg_dict), 10)
163+
self.assertEqual(len(msg_dict), 9)
166164

167165
self.assertIn("pg_name", msg_dict.keys())
168166
self.assertEqual("None", msg_dict["pg_name"])
169167

170168
self.assertIn("func_name", msg_dict.keys())
171169
self.assertEqual("_dummy_sleep", msg_dict["func_name"])
172170

173-
self.assertIn("args", msg_dict.keys())
174-
175171
self.assertIn("backend", msg_dict.keys())
176172
self.assertEqual("nccl", msg_dict["backend"])
177173

torch/distributed/c10d_logger.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ def _get_msg_dict(func_name, *args, **kwargs) -> Dict[str, Any]:
5353
group = kwargs.get("group") or kwargs.get("process_group")
5454
msg_dict = {
5555
"func_name": f"{func_name}",
56-
"args": f"{args}, {kwargs}",
5756
"pg_name": f"{dist._get_process_group_name(kwargs.get('pg'))}", # type: ignore[arg-type]
5857
"backend": f"{dist.get_backend(group)}",
5958
"world_size": f"{dist.get_world_size()}",
@@ -67,7 +66,6 @@ def _get_msg_dict(func_name, *args, **kwargs) -> Dict[str, Any]:
6766
else:
6867
msg_dict = {
6968
"func_name": f"{func_name}",
70-
"args": f"{args}, {kwargs}",
7169
}
7270
return msg_dict
7371

0 commit comments

Comments
 (0)