Skip to content

Commit 4ac8aed

Browse files
committed
Prepare to enable react-a11y rules
When I first added these, I left TODO notes to come back and evaluate enabling them. I've gone through and think that we should definitely at least enable the rules that enforce basic spec compliance (e.g. that props don't have typos and that all of the required props are provided for the given role). Since these deal with basic correctness, I don't think we need to add any verbiage to the style guide for these rules. We still have some more that we should evaluate and decide about enabling here, but this is a good step in the right direction.
1 parent c7faa91 commit 4ac8aed

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

packages/eslint-config-airbnb/rules/react-a11y.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,18 +12,18 @@ module.exports = {
1212
'jsx-a11y/aria-role': 2,
1313

1414
// Enforce all aria-* props are valid.
15-
// TODO: evaluate
15+
// TODO: enable
1616
// https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/aria-props.md
1717
'jsx-a11y/aria-props': 0,
1818

1919
// Enforce ARIA state and property values are valid.
20-
// TODO: evaluate
20+
// TODO: enable
2121
// https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/aria-proptypes.md
2222
'jsx-a11y/aria-proptypes': 0,
2323

2424
// Enforce that elements that do not support ARIA roles, states, and
2525
// properties do not have those attributes.
26-
// TODO: evaluate
26+
// TODO: enable
2727
// https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/aria-unsupported-elements.md
2828
'jsx-a11y/aria-unsupported-elements': 0,
2929

@@ -69,13 +69,13 @@ module.exports = {
6969

7070
// Enforce that elements with ARIA roles must have all required attributes
7171
// for that role.
72-
// TODO: evaluate
72+
// TODO: enable
7373
// https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/role-has-required-aria-props.md
7474
'jsx-a11y/role-has-required-aria-props': 0,
7575

7676
// Enforce that elements with explicit or implicit roles defined contain
7777
// only aria-* properties supported by that role.
78-
// TODO: evaluate
78+
// TODO: enable
7979
// https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/role-supports-aria-props.md
8080
'jsx-a11y/role-supports-aria-props': 0,
8181

0 commit comments

Comments
 (0)