From 8b48e11689f5b13782ed7fe94650157c4debe21f Mon Sep 17 00:00:00 2001 From: Matt Brophy Date: Thu, 11 Dec 2025 10:56:34 -0500 Subject: [PATCH] Add node 20.18 E2E run to dev package PRs --- .github/workflows/integration-pr-windows-macos.yml | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/.github/workflows/integration-pr-windows-macos.yml b/.github/workflows/integration-pr-windows-macos.yml index f3d12c7681..dfda99d9d3 100644 --- a/.github/workflows/integration-pr-windows-macos.yml +++ b/.github/workflows/integration-pr-windows-macos.yml @@ -1,6 +1,7 @@ name: PR (Full) -# PRs touching react-router-dev will also run on Windows and OSX +# PRs touching @react-router/dev will also run on Ubuntu/Firefox, Windows/Edge and +# OSX/WebKit as well as an Ubuntu/Chromium run on Node 20.18. on: pull_request: @@ -15,6 +16,15 @@ concurrency: cancel-in-progress: true jobs: + integration-chromium: + name: "👀 Integration Test" + if: github.repository == 'remix-run/react-router' + uses: ./.github/workflows/shared-integration.yml + with: + os: "ubuntu-latest" + node_version: "[20.18]" + browser: '["chromium"]' + integration-firefox: name: "👀 Integration Test" if: github.repository == 'remix-run/react-router' @@ -42,4 +52,4 @@ jobs: os: "macos-latest" node_version: "[22]" browser: '["webkit"]' - timeout: 40 + timeout: 50