test: fix more tests (microsoft#38597)

pavelfeldman · web-flow · commit d810ea863d9a · 2025-12-17T19:02:52.000-08:00
diff --git a/tests/mcp/autowait.spec.ts b/tests/mcp/autowait.spec.ts
@@ -16,7 +16,7 @@
 
 import { test, expect } from './fixtures';
 
-test('racy navigation destroys context', async ({ client, server, mcpBrowser }) => {
+test('racy navigation destroys context', async ({ client, server }) => {
   server.setContent('/', `
     <button onclick='setTimeout(() => window.location = "about:blank", 100)'>Submit</button>
   `, 'text/html');
diff --git a/tests/mcp/fixtures.ts b/tests/mcp/fixtures.ts
@@ -56,6 +56,7 @@ export type StartClient = (options?: {
   roots?: { name: string, uri: string }[],
   rootsResponseDelay?: number,
   env?: NodeJS.ProcessEnv,
+  noTimeoutForTest?: boolean,
 }) => Promise<{ client: Client, stderr: () => string }>;
 
 
@@ -107,6 +108,8 @@ export const test = serverTest.extend<TestFixtures & TestOptions, WorkerFixtures
           await fs.promises.writeFile(configFile, JSON.stringify(options.config, null, 2));
           args.push(`--config=${path.relative(configDir, configFile)}`);
         }
+        if (!options?.noTimeoutForTest)
+          args.push('--timeout-action=10000');
       }
 
       if (options?.args)
diff --git a/tests/mcp/timeouts.spec.ts b/tests/mcp/timeouts.spec.ts
@@ -16,7 +16,8 @@
 
 import { test, expect } from './fixtures';
 
-test('action timeout (default)', async ({ client, server }) => {
+test('action timeout (default)', async ({ server, startClient }) => {
+  const { client } = await startClient({ noTimeoutForTest: true });
   server.setContent('/', `
     <!DOCTYPE html>
     <html>
diff --git a/tests/playwright-test/playwright.spec.ts b/tests/playwright-test/playwright.spec.ts
@@ -890,7 +890,7 @@ test('page.pause() should disable test timeout', async ({ runInlineTest }) => {
         console.log('success!');
       });
     `,
-  }, { headed: true });
+  }, { headed: true });  // This needs to be headed otherwise entire worker is gone.
   expect(result.exitCode).toBe(0);
   expect(result.passed).toBe(1);
   expect(result.output).toContain('success!');

Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,7 @@ export type StartClient = (options?: {`
`56`	`56`	`roots?: { name: string, uri: string }[],`
`57`	`57`	`rootsResponseDelay?: number,`
`58`	`58`	`env?: NodeJS.ProcessEnv,`
	`59`	`+ noTimeoutForTest?: boolean,`
`59`	`60`	`}) => Promise<{ client: Client, stderr: () => string }>;`
`60`	`61`
`61`	`62`
`@@ -107,6 +108,8 @@ export const test = serverTest.extend<TestFixtures & TestOptions, WorkerFixtures`
`107`	`108`	`await fs.promises.writeFile(configFile, JSON.stringify(options.config, null, 2));`
`108`	`109`	args.push(`--config=${path.relative(configDir, configFile)}`);
`109`	`110`	`}`
	`111`	`+ if (!options?.noTimeoutForTest)`
	`112`	`+ args.push('--timeout-action=10000');`
`110`	`113`	`}`
`111`	`114`
`112`	`115`	`if (options?.args)`