Clean up unused code in restart server button (vercel#82409)

Author: devjiwonchoi

packages/next/src/next-devtools/dev-overlay/components/errors/error-overlay-toolbar/restart-server-button.tsx

@@ -1,12 +1,11 @@
-import type { OverlayDispatch, OverlayState } from '../../shared'
+import type { OverlayState } from '../../shared'
 import type { StackFrame } from '../../../shared/stack-frame'
 
 import { useMemo, useState, useEffect } from 'react'
 import {
   getErrorByType,
   type ReadyRuntimeError,
 } from '../../utils/get-error-by-type'
-import { usePersistentCacheErrorDetection } from '../../components/errors/error-overlay-toolbar/restart-server-button'
 
 export type SupportedErrorEvent = {
   id: number
@@ -22,7 +21,6 @@ type Props = {
   }) => React.ReactNode
   state: OverlayState
   isAppDir: boolean
-  dispatch: OverlayDispatch
 }
 
 export const RenderError = (props: Props) => {
@@ -36,7 +34,7 @@ export const RenderError = (props: Props) => {
   }
 }
 
-const RenderRuntimeError = ({ children, state, isAppDir, dispatch }: Props) => {
+const RenderRuntimeError = ({ children, state, isAppDir }: Props) => {
   const { errors } = state
 
   const [lookups, setLookups] = useState<{
@@ -65,8 +63,6 @@ const RenderRuntimeError = ({ children, state, isAppDir, dispatch }: Props) => {
     return [ready, next]
   }, [errors, lookups])
 
-  usePersistentCacheErrorDetection({ errors, dispatch })
-
   useEffect(() => {
     if (nextError == null) {
       return

packages/next/src/next-devtools/dev-overlay/container/runtime-error/render-error.tsx

@@ -33,7 +33,7 @@ export function DevOverlay() {
       <ComponentStyles />
       <DarkTheme />
 
-      <RenderError state={state} dispatch={dispatch} isAppDir={true}>
+      <RenderError state={state} isAppDir={true}>
         {({ runtimeErrors, totalErrorCount }) => {
           return (
             <>

packages/next/src/next-devtools/dev-overlay/dev-overlay.tsx

@@ -52,10 +52,6 @@ export interface OverlayState {
   readonly staticIndicator: boolean
   readonly showIndicator: boolean
   readonly disableDevIndicator: boolean
-  /** Whether to show the restart server button in the panel UI. Currently
-   *  only used when Turbopack + Persistent Cache is enabled.
-   */
-  readonly showRestartServerButton: boolean
   readonly debugInfo: DebugInfo
   readonly routerType: 'pages' | 'app'
   /** This flag is used to handle the Error Overlay state in the "old" overlay.
@@ -105,7 +101,6 @@ export const ACTION_DEVTOOLS_POSITION = 'devtools-position'
 export const ACTION_DEVTOOLS_PANEL_POSITION = 'devtools-panel-position'
 export const ACTION_DEVTOOLS_PANEL_SIZE = 'devtools-panel-size'
 export const ACTION_DEVTOOLS_SCALE = 'devtools-scale'
-export const ACTION_RESTART_SERVER_BUTTON = 'restart-server-button'
 
 export const ACTION_DEVTOOLS_CONFIG = 'devtools-config'
 
@@ -216,11 +211,6 @@ export interface DevToolUpdateRouteStateAction {
   page: string
 }
 
-export interface RestartServerButtonAction {
-  type: typeof ACTION_RESTART_SERVER_BUTTON
-  showRestartServerButton: boolean
-}
-
 export interface DevToolsConfigAction {
   type: typeof ACTION_DEVTOOLS_CONFIG
   devToolsConfig: DevToolsConfig
@@ -248,7 +238,6 @@ export type DispatcherEvent =
   | DevToolsPanelPositionAction
   | DevToolsScaleAction
   | DevToolUpdateRouteStateAction
-  | RestartServerButtonAction
   | DevIndicatorSetAction
   | DevToolsConfigAction
 
@@ -291,7 +280,6 @@ export const INITIAL_OVERLAY_STATE: Omit<
   refreshState: { type: 'idle' },
   versionInfo: { installed: '0.0.0', staleness: 'unknown' },
   debugInfo: { devtoolsFrontendUrl: undefined },
-  showRestartServerButton: false,
   devToolsPosition: 'bottom-left',
   devToolsPanelPosition: {
     [STORE_KEY_SHARED_PANEL_LOCATION]: 'bottom-left',
@@ -479,12 +467,6 @@ export function useErrorOverlayReducer(
         case ACTION_DEVTOOL_UPDATE_ROUTE_STATE: {
           return { ...state, page: action.page }
         }
-        case ACTION_RESTART_SERVER_BUTTON: {
-          return {
-            ...state,
-            showRestartServerButton: action.showRestartServerButton,
-          }
-        }
         case ACTION_DEVTOOLS_CONFIG: {
           const {
             theme,

packages/next/src/next-devtools/dev-overlay/icons/refresh-clock-wise.tsx

@@ -21,7 +21,6 @@ import {
   ACTION_REFRESH,
   ACTION_RENDERING_INDICATOR_HIDE,
   ACTION_RENDERING_INDICATOR_SHOW,
-  ACTION_RESTART_SERVER_BUTTON,
   ACTION_STATIC_INDICATOR,
   ACTION_UNHANDLED_ERROR,
   ACTION_UNHANDLED_REJECTION,
@@ -82,7 +81,6 @@ export function useStorybookOverlayReducer(initialState?: OverlayState) {
         case ACTION_REFRESH:
         case ACTION_RENDERING_INDICATOR_HIDE:
         case ACTION_RENDERING_INDICATOR_SHOW:
-        case ACTION_RESTART_SERVER_BUTTON:
         case ACTION_STATIC_INDICATOR:
         case ACTION_UNHANDLED_ERROR:
         case ACTION_UNHANDLED_REJECTION:

packages/next/src/next-devtools/dev-overlay/shared.ts

@@ -20,7 +20,6 @@ import { DEV_TOOLS_INFO_TURBOPACK_INFO_STYLES } from '../components/errors/dev-t
 import { DEV_TOOLS_INFO_ROUTE_INFO_STYLES } from '../components/errors/dev-tools-indicator/dev-tools-info/route-info'
 import { DEV_TOOLS_INFO_USER_PREFERENCES_STYLES } from '../components/errors/dev-tools-indicator/dev-tools-info/user-preferences'
 import { FADER_STYLES } from '../components/fader'
-import { RESTART_SERVER_BUTTON_STYLES } from '../components/errors/error-overlay-toolbar/restart-server-button'
 import { CALL_STACK_STYLES } from '../components/call-stack/call-stack'
 import { ISSUE_FEEDBACK_BUTTON_STYLES } from '../components/errors/error-overlay-toolbar/issue-feedback-button'
 import { ERROR_CONTENT_SKELETON_STYLES } from '../container/runtime-error/error-content-skeleton'
@@ -47,7 +46,6 @@ export function ComponentStyles() {
         ${containerErrorStyles}
         ${containerRuntimeErrorStyles}
         ${versionStaleness}
-        ${RESTART_SERVER_BUTTON_STYLES}
         ${DEV_TOOLS_INFO_STYLES}
         ${DEV_TOOLS_INFO_TURBOPACK_INFO_STYLES}
         ${DEV_TOOLS_INFO_ROUTE_INFO_STYLES}