Migrate async_migrate_entry test calls to async_setup in growatt_server (home-assistant#172587)

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: johanzander

tests/components/growatt_server/test_init.py

@@ -9,7 +9,6 @@
 import requests
 from syrupy.assertion import SnapshotAssertion
 
-from homeassistant.components.growatt_server import async_migrate_entry
 from homeassistant.components.growatt_server.const import (
     AUTH_API_TOKEN,
     AUTH_PASSWORD,
@@ -332,6 +331,7 @@ async def test_classic_api_setup(
         ),
     ],
 )
+@pytest.mark.usefixtures("mock_growatt_v1_api", "mock_growatt_classic_api")
 async def test_migrate_config_without_auth_type(
     hass: HomeAssistant,
     config_data: dict[str, str],
@@ -353,11 +353,8 @@ async def test_migrate_config_without_auth_type(
     )
 
     mock_config_entry.add_to_hass(hass)
-
-    # Execute migration
-    # pylint: disable-next=home-assistant-tests-direct-async-migrate-entry
-    migration_result = await async_migrate_entry(hass, mock_config_entry)
-    assert migration_result is True
+    await hass.config_entries.async_setup(mock_config_entry.entry_id)
+    await hass.async_block_till_done()
 
     # Verify version was updated to 1.1
     assert mock_config_entry.version == 1
@@ -366,6 +363,9 @@ async def test_migrate_config_without_auth_type(
     # Verify auth_type field was added during migration
     assert mock_config_entry.data[CONF_AUTH_TYPE] == expected_auth_type
 
+    # Verify setup completed successfully after migration
+    assert mock_config_entry.state is ConfigEntryState.LOADED
+
 
 async def test_migrate_legacy_config_no_auth_fields(
     hass: HomeAssistant,
@@ -385,17 +385,13 @@ async def test_migrate_legacy_config_no_auth_fields(
     )
 
     mock_config_entry.add_to_hass(hass)
+    await hass.config_entries.async_setup(mock_config_entry.entry_id)
+    await hass.async_block_till_done()
 
-    # Migration should succeed (only updates version)
-    # pylint: disable-next=home-assistant-tests-direct-async-migrate-entry
-    migration_result = await async_migrate_entry(hass, mock_config_entry)
-    assert migration_result is True
-
-    # Verify version was updated
+    # Migration succeeds (version bumped) but setup fails due to missing auth fields
     assert mock_config_entry.version == 1
     assert mock_config_entry.minor_version == 1
-
-    # Note: Setup will fail later due to missing auth fields in async_setup_entry
+    assert mock_config_entry.state is ConfigEntryState.SETUP_ERROR
 
 
 @pytest.mark.parametrize(
@@ -613,7 +609,6 @@ async def test_migrate_version_bump(
     This test verifies that:
     - Migration successfully resolves DEFAULT_PLANT_ID ("0") to actual plant_id
     - Config entry version is bumped from 1.0 to 1.1
-    - API instance is cached for setup to reuse (rate limit optimization)
     """
     # Create a version 1.0 config entry with DEFAULT_PLANT_ID
     mock_config_entry = MockConfigEntry(
@@ -631,21 +626,21 @@ async def test_migrate_version_bump(
         minor_version=0,
     )
 
-    # Mock successful API responses for migration
+    # Mock successful API responses for migration and setup
     mock_growatt_classic_api.login.return_value = {
         "success": True,
         "user": {"id": 123456},
     }
     mock_growatt_classic_api.plant_list.return_value = {
         "data": [{"plantId": "RESOLVED_PLANT_789", "plantName": "My Plant"}]
     }
+    mock_growatt_classic_api.device_list.return_value = [
+        {"deviceSn": "TLX123456", "deviceType": "tlx"}
+    ]
 
     mock_config_entry.add_to_hass(hass)
-
-    # Execute migration
-    # pylint: disable-next=home-assistant-tests-direct-async-migrate-entry
-    migration_result = await async_migrate_entry(hass, mock_config_entry)
-    assert migration_result is True
+    await hass.config_entries.async_setup(mock_config_entry.entry_id)
+    await hass.async_block_till_done()
 
     # Verify version was updated to 1.1
     assert mock_config_entry.version == 1
@@ -654,8 +649,8 @@ async def test_migrate_version_bump(
     # Verify plant_id was resolved to actual plant_id (not DEFAULT_PLANT_ID)
     assert mock_config_entry.data[CONF_PLANT_ID] == "RESOLVED_PLANT_789"
 
-    # Verify API instance was cached for setup to reuse
-    assert f"{CACHED_API_KEY}{mock_config_entry.entry_id}" in hass.data[DOMAIN]
+    # Verify setup completed successfully after migration
+    assert mock_config_entry.state is ConfigEntryState.LOADED
 
 
 async def test_setup_reuses_cached_api_from_migration(
@@ -718,17 +713,12 @@ async def test_setup_reuses_cached_api_from_migration(
     }
 
     mock_config_entry.add_to_hass(hass)
-
-    # Run migration first (resolves plant_id and caches authenticated API)
-    # pylint: disable-next=home-assistant-tests-direct-async-migrate-entry
-    await async_migrate_entry(hass, mock_config_entry)
+    await hass.config_entries.async_setup(mock_config_entry.entry_id)
+    await hass.async_block_till_done()
 
     # Verify migration successfully resolved plant_id
     assert mock_config_entry.data[CONF_PLANT_ID] == "RESOLVED_PLANT_789"
 
-    # Now setup the integration (should reuse cached API from migration)
-    await setup_integration(hass, mock_config_entry)
-
     # Verify integration loaded successfully
     assert mock_config_entry.state is ConfigEntryState.LOADED
 
@@ -783,13 +773,11 @@ async def test_migrate_failure_returns_false(
     )
 
     mock_config_entry.add_to_hass(hass)
+    await hass.config_entries.async_setup(mock_config_entry.entry_id)
+    await hass.async_block_till_done()
 
-    # Execute migration (should fail gracefully)
-    # pylint: disable-next=home-assistant-tests-direct-async-migrate-entry
-    migration_result = await async_migrate_entry(hass, mock_config_entry)
-
-    # Verify migration returned False (will retry on next restart)
-    assert migration_result is False
+    # Verify migration failed (entry is in migration error state)
+    assert mock_config_entry.state is ConfigEntryState.MIGRATION_ERROR
 
     # Verify version was NOT bumped (remains 1.0)
     assert mock_config_entry.version == 1
@@ -803,6 +791,7 @@ async def test_migrate_failure_returns_false(
     assert "Migration will retry on next restart" in caplog.text
 
 
+@pytest.mark.usefixtures("mock_growatt_classic_api")
 async def test_migrate_already_migrated(
     hass: HomeAssistant,
 ) -> None:
@@ -823,11 +812,8 @@ async def test_migrate_already_migrated(
     )
 
     mock_config_entry.add_to_hass(hass)
-
-    # Call migration function
-    # pylint: disable-next=home-assistant-tests-direct-async-migrate-entry
-    migration_result = await async_migrate_entry(hass, mock_config_entry)
-    assert migration_result is True
+    await hass.config_entries.async_setup(mock_config_entry.entry_id)
+    await hass.async_block_till_done()
 
     # Verify version remains 1.1 (no change)
     assert mock_config_entry.version == 1
@@ -836,6 +822,9 @@ async def test_migrate_already_migrated(
     # Plant ID should remain unchanged
     assert mock_config_entry.data[CONF_PLANT_ID] == "specific_plant_123"
 
+    # Verify setup completed successfully
+    assert mock_config_entry.state is ConfigEntryState.LOADED
+
 
 @pytest.mark.usefixtures("init_integration")
 async def test_dynamic_device_added(