Skip to content

Commit 4593059

Browse files
abmantisCopilot
andauthored
Add "review" claude skill and use it in "gitbhub-pr-review" (home-assistant#172797)
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
1 parent 593ae9e commit 4593059

2 files changed

Lines changed: 40 additions & 33 deletions

File tree

.claude/skills/github-pr-reviewer/SKILL.md

Lines changed: 2 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -8,39 +8,8 @@ description: Reviews GitHub pull requests and provides feedback comments. This i
88
## Follow these steps:
99
1. Use 'gh pr view' to get the PR details and description.
1010
2. Use 'gh pr diff' to see all the changes in the PR.
11-
3. Analyze the code changes for:
12-
- Code quality and style consistency
13-
- Potential bugs or issues
14-
- Performance implications
15-
- Security concerns
16-
- Test coverage
17-
- Documentation updates if needed
18-
4. Ensure any existing review comments have been addressed.
19-
5. Generate constructive review comments in the CONSOLE. DO NOT POST TO GITHUB YOURSELF.
20-
21-
## Verification:
22-
23-
- After the review, run parallel subagents for each finding to double check it.
24-
- Spawn up to a maximum of 10 parallel subagents at a time.
25-
- Gather the results from the subagents and summarize them in the final review comments.
26-
11+
3. Review the changes following the `review` skill. It is VERY IMPORTANT to follow the `review` skill instructions.
12+
4. Check if all existing review comments have been addressed.
2713

2814
## IMPORTANT:
29-
- Just review. DO NOT make any changes
30-
- Be constructive and specific in your comments
31-
- Suggest improvements where appropriate
3215
- Only provide review feedback in the CONSOLE. DO NOT ACT ON GITHUB.
33-
- No need to run tests or linters, just review the code changes.
34-
- No need to highlight things that are already good.
35-
36-
## Output format:
37-
- List specific comments for each file/line that needs attention.
38-
- In the end, summarize with an overall assessment (approve, request changes, or comment) and bullet point list of changes suggested, if any.
39-
- Example output:
40-
```
41-
Overall assessment: request changes.
42-
- [CRITICAL] sensor.py:143 - Memory leak
43-
- [PROBLEM] data_processing.py:87 - Inefficient algorithm
44-
- [SUGGESTION] test_init.py:45 - Improve x variable name
45-
```
46-
- Make sure to include the file and line number when possible in the bullet points.

.claude/skills/review/SKILL.md

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
---
2+
name: review
3+
description: Reviews code changes and provides constructive feedback. Should be used when a review is requested to provide a consistent review behavior and output format. This skill can be used for code reviews in general, not just for GitHub pull requests.
4+
---
5+
6+
# Review Code Changes
7+
8+
## Analyze the code changes for:
9+
- Code quality and style consistency
10+
- Potential bugs or issues
11+
- Performance implications
12+
- Security concerns
13+
- Test coverage
14+
- Documentation updates if needed
15+
16+
## Verification:
17+
- After the review, run parallel subagents for each finding to double-check it.
18+
- Spawn up to a maximum of 10 parallel subagents at a time.
19+
- Gather the results from the subagents and summarize them in the final review comments.
20+
21+
## IMPORTANT:
22+
- Just review. DO NOT make any changes.
23+
- Be constructive and specific in your comments.
24+
- Suggest improvements where appropriate.
25+
- No need to run tests or linters, just review the code changes.
26+
- No need to highlight things that are already good.
27+
28+
## Output format:
29+
- List specific comments for each file/line that needs attention.
30+
- In the end, summarize with an overall assessment (approve, request changes, or comment) and bullet point list of changes suggested, if any.
31+
- Example output:
32+
```
33+
Overall assessment: request changes.
34+
- [CRITICAL] sensor.py:143 - Memory leak
35+
- [PROBLEM] data_processing.py:87 - Inefficient algorithm
36+
- [SUGGESTION] test_init.py:45 - Improve x variable name
37+
```
38+
- Make sure to include the file and line number when possible in the bullet points.

0 commit comments

Comments
 (0)