Skip to content

Commit 10bbe4d

Browse files
authored
fix: data source creation from the DataSourceDropdown footer (baserow#5255)
1 parent 3e32bd6 commit 10bbe4d

2 files changed

Lines changed: 18 additions & 2 deletions

File tree

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"type": "bug",
3+
"message": "Resolved a bug which prevented users from creating data sources from the data source dropdown's footer.",
4+
"issue_origin": "github",
5+
"issue_number": 5118,
6+
"domain": "builder",
7+
"bullet_points": [],
8+
"created_at": "2026-04-22"
9+
}

web-frontend/modules/builder/components/dataSource/DataSourceDropdown.vue

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,10 @@
4848
<DataSourceCreateEditModal
4949
:key="modalKey"
5050
ref="dataSourceCreateEditModal"
51+
:data-source-id="currentDataSourceId"
52+
@data-source-created="currentDataSourceId = $event.id"
5153
@updated="onDataSourceUpdated"
54+
@hidden="currentDataSourceId = null"
5255
/>
5356
</div>
5457
</template>
@@ -84,6 +87,7 @@ export default {
8487
data() {
8588
return {
8689
modalKey: 0,
90+
currentDataSourceId: null,
8791
}
8892
},
8993
computed: {
@@ -112,8 +116,11 @@ export default {
112116
: this.$t('integrationsCommon.singleRow')
113117
return `${dataSource.name} (${suffix})`
114118
},
115-
openDataSourceModal() {
116-
this.$refs.dataSourceCreateEditModal.show()
119+
async openDataSourceModal() {
120+
this.currentDataSourceId = null
121+
this.modalKey++
122+
await this.$nextTick()
123+
this.$refs.dataSourceCreateEditModal?.show()
117124
},
118125
/**
119126
* When a data source is updated (i.e. the user has created the record,

0 commit comments

Comments
 (0)