MM-69003 Update ESLint and related dependencies (mattermost#37039)

* Remove everything

* Re-add most ESLint plugins and run --fix

* Additional fixes

* Fix or disable linter warnings caused by require imports

* Fix how prop types for SearchResults are defined

* More additional fixes

* Update deprecated stylistic rule names

* Remove deprecated .eslintignore

* Update eslint-plugin-react-hooks

* Enable react-hooks/error-boundaries

* Fix react-hooks/static-components wherever possible

* Fix react-hooks/use-memo wherever possible

* Disable warnings for new rules and update comment

* Update eslint-plugin-no-only-tests

* Update eslint dependencies in E2E test packages

* Remove now-uneeded patch

* Address Coderabbit feedback

* Actually fix inverted tooltip logic

Author: hmhealey

e2e-tests/cypress/package-lock.json

@@ -3,11 +3,8 @@
   "devDependencies": {
     "@aws-sdk/client-s3": "3.1030.0",
     "@aws-sdk/lib-storage": "3.1030.0",
-    "@babel/eslint-parser": "7.28.6",
-    "@babel/eslint-plugin": "7.27.1",
     "@cypress/request": "3.0.10",
     "@cypress/webpack-preprocessor": "7.1.0",
-    "@eslint/js": "9.39.3",
     "@mattermost/client": "11.5.0",
     "@mattermost/eslint-plugin": "file:../../webapp/platform/eslint-plugin",
     "@mattermost/types": "11.5.0",
@@ -24,8 +21,6 @@
     "@types/mochawesome": "6.2.5",
     "@types/recursive-readdir": "2.2.4",
     "@types/shelljs": "0.10.0",
-    "@typescript-eslint/eslint-plugin": "8.58.2",
-    "@typescript-eslint/parser": "8.58.2",
     "async": "3.2.6",
     "authenticator": "1.1.5",
     "axios": "1.15.0",
@@ -43,8 +38,8 @@
     "deepmerge": "4.3.1",
     "dotenv": "17.4.2",
     "eslint": "9.39.3",
-    "eslint-plugin-cypress": "6.3.1",
-    "eslint-plugin-no-only-tests": "3.3.0",
+    "eslint-plugin-cypress": "^6.3.1",
+    "eslint-plugin-no-only-tests": "^3.4.0",
     "express": "5.2.1",
     "extract-zip": "2.0.1",
     "globals": "17.5.0",
@@ -72,7 +67,6 @@
     "timezones.json": "1.7.2",
     "ts-loader": "9.5.7",
     "typescript": "6.0.2",
-    "typescript-eslint": "8.58.2",
     "uuid": "13.0.0",
     "yargs": "18.0.0"
   },

e2e-tests/cypress/package.json

@@ -36,7 +36,7 @@ export default [
             '@stylistic/wrap-regex': 'off', // Covered by Prettier
             '@typescript-eslint/explicit-module-boundary-types': 'off',
             '@typescript-eslint/no-explicit-any': 'off',
-            '@typescript-eslint/no-var-requires': 'off',
+            '@typescript-eslint/no-require-imports': 'off',
             'func-names': 'off',
             'max-lines': ['warn', {max: 800, skipBlankLines: true, skipComments: true}],
             'no-await-in-loop': 'off',

e2e-tests/playwright/eslint.config.mjs

@@ -11,8 +11,7 @@ import {resolvePlaywrightPath} from './util';
 const commonAssetPath = path.resolve(__dirname, 'asset');
 export const assetPath = resolvePlaywrightPath('asset');
 
-const availableFiles = ['mattermost-icon_128x128.png'] as const;
-type AvailableFilename = (typeof availableFiles)[number];
+type AvailableFilename = 'mattermost-icon_128x128.png';
 
 /**
  * Reads file data and creates a File object.

e2e-tests/playwright/lib/src/file.ts

@@ -40,7 +40,7 @@
     "cross-env": "10.1.0",
     "dayjs": "1.11.20",
     "eslint": "9.39.2",
-    "eslint-import-resolver-typescript": "4.4.4",
+    "eslint-import-resolver-typescript": "^4.4.5",
     "glob": "13.0.6",
     "luxon": "3.7.2",
     "prettier": "3.8.2",

e2e-tests/playwright/package-lock.json

@@ -1,13 +1,15 @@
 // Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
 // See LICENSE.txt for license information.
 
+import {defineConfig, globalIgnores} from 'eslint/config';
 import formatjsPlugin from 'eslint-plugin-formatjs';
 import noOnlyTestsPlugin from 'eslint-plugin-no-only-tests';
 
 import eslintPlugin from '@mattermost/eslint-plugin';
 
-export default [
+export default defineConfig([
     ...eslintPlugin.configs.react,
+    globalIgnores(['./dist']),
     {
         plugins: {
             formatjs: formatjsPlugin,
@@ -83,4 +85,4 @@ export default [
             },
         },
     },
-];
+]);

e2e-tests/playwright/package.json

@@ -137,14 +137,14 @@
     "emoji-datasource": "6.1.1",
     "emoji-datasource-apple": "6.1.1",
     "emoji-datasource-google": "6.1.1",
-    "eslint-plugin-no-only-tests": "3.1.0",
+    "eslint-import-resolver-webpack": "0.13.11",
+    "eslint-plugin-formatjs": "6.4.15",
+    "eslint-plugin-no-only-tests": "3.4.0",
     "external-remotes-plugin": "1.0.0",
     "html-loader": "5.1.0",
     "html-webpack-plugin": "5.5.0",
     "identity-obj-proxy": "3.0.0",
     "image-minimizer-webpack-plugin": "5.0.0",
-    "svgo": "2.8.2",
-    "sharp": "0.34.5",
     "jest": "30.1.3",
     "jest-canvas-mock": "2.5.0",
     "jest-cli": "30.1.3",
@@ -155,11 +155,14 @@
     "prettier": "2.3.2",
     "redux-mock-store": "1.5.4",
     "redux-persist-node-storage": "2.0.0",
+    "sharp": "0.34.5",
     "stylelint": "16.10.0",
     "stylelint-config-idiomatic-order": "10.0.0",
     "stylelint-config-recommended-scss": "14.1.0",
     "stylelint-order": "6.0.4",
     "stylelint-scss": "6.8.1",
+    "svgo": "2.8.2",
+    "typescript-eslint-language-service": "5.0.5",
     "webpack-pwa-manifest": "4.3.0",
     "yargs": "17.7.2"
   },

webapp/channels/.eslintignore

@@ -26,7 +26,7 @@ export function validateBusinessEmail(email = '') {
         try {
             const res = await Client4.validateBusinessEmail(email);
             return res.data.is_valid;
-        } catch (error) {
+        } catch {
             return false;
         }
     };
@@ -37,7 +37,7 @@ export function validateWorkspaceBusinessEmail() {
         try {
             const res = await Client4.validateWorkspaceBusinessEmail();
             return res.data.is_valid;
-        } catch (error) {
+        } catch {
             return false;
         }
     };