🐛 Stopped injecting portal when portal.url is set to 'false' in config file (TryGhost#21936)

no ref 

Co-authored-by: Ludovic Toinel <ltoinel@free.fr>
Co-authored-by: Cathy Sarisky <catsarisky@gmail.com>
Co-authored-by: Steve Larson <9larsons@gmail.com>

Author: 4 people

ghost/core/core/frontend/helpers/ghost_head.js

@@ -57,19 +57,21 @@ function getMembersHelper(data, frontendKey, excludeList) {
     if (!excludeList.has('portal')) {
         const {scriptUrl} = getFrontendAppConfig('portal');
 
-        const colorString = (_.has(data, 'site._preview') && data.site.accent_color) ? data.site.accent_color : '';
-        const attributes = {
-            i18n: true,
-            ghost: urlUtils.getSiteUrl(),
-            key: frontendKey,
-            api: urlUtils.urlFor('api', {type: 'content'}, true),
-            locale: settingsCache.get('locale') || 'en'
-        };
-        if (colorString) {
-            attributes['accent-color'] = colorString;
+        if (scriptUrl) {
+            const colorString = (_.has(data, 'site._preview') && data.site.accent_color) ? data.site.accent_color : '';
+            const attributes = {
+                i18n: true,
+                ghost: urlUtils.getSiteUrl(),
+                key: frontendKey,
+                api: urlUtils.urlFor('api', {type: 'content'}, true),
+                locale: settingsCache.get('locale') || 'en'
+            };
+            if (colorString) {
+                attributes['accent-color'] = colorString;
+            }
+            const dataAttributes = getDataAttributes(attributes);
+            membersHelper += `<script defer src="${scriptUrl}" ${dataAttributes} crossorigin="anonymous"></script>`;
         }
-        const dataAttributes = getDataAttributes(attributes);
-        membersHelper += `<script defer src="${scriptUrl}" ${dataAttributes} crossorigin="anonymous"></script>`;
     }
     if (!excludeList.has('cta_styles')) {
         membersHelper += (`<style id="gh-members-styles">${templateStyles}</style>`);

ghost/core/test/unit/frontend/helpers/ghost-head.test.js

@@ -1271,6 +1271,22 @@ describe('{{ghost_head}} helper', function () {
                 }
             }));
         });
+        it('does not inject the portal script when portal url is disabled', async function () {
+            getStub.withArgs('members_enabled').returns(true);
+            getStub.withArgs('paid_members_enabled').returns(true);
+            configUtils.set({'portal:url': false});
+
+            const rendered = (await ghost_head(testUtils.createHbsResponse({
+                locals: {
+                    relativeUrl: '/',
+                    context: ['home', 'index'],
+                    safeVersion: '4.3'
+                }
+            }))).toString();
+
+            assert.doesNotMatch(rendered, /src="false"/);
+            assert.doesNotMatch(rendered, /data-ghost=/);
+        });
     });
 
     describe('search scripts', function () {