Skip to content

Commit bee5db4

Browse files
authored
Read installed @playwright/test version when building the e2e image tag (TryGhost#27880)
no ref \`e2e/scripts/load-playwright-container-env.sh\` constructs the Playwright Docker image tag from the version declared in \`e2e/package.json\`. Switched from reading the manifest field (\`devDependencies["@playwright/test"]\`) to reading the installed package's actual version (\`require("@playwright/test/package.json").version\`).
1 parent b0fb941 commit bee5db4

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

e2e/scripts/load-playwright-container-env.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ REPO_ROOT="$(cd "$SCRIPT_DIR/../.." && pwd)"
1010

1111
cd "$REPO_ROOT"
1212

13-
PLAYWRIGHT_VERSION="$(node -p 'require("./e2e/package.json").devDependencies["@playwright/test"]')"
13+
PLAYWRIGHT_VERSION="$(cd e2e && node -p "require('@playwright/test/package.json').version")"
1414
PLAYWRIGHT_IMAGE="mcr.microsoft.com/playwright:v${PLAYWRIGHT_VERSION}-noble"
1515
WORKSPACE_PATH="${GITHUB_WORKSPACE:-$REPO_ROOT}"
1616

0 commit comments

Comments
 (0)