🐛 Fixed crash in Redis adapter when storeConfig is not provided

no-issue

When storeConfig was omitted from the Redis cache adapter config,
the retryStrategy callback would throw a TypeError whenever ioredis
tried to reconnect to Redis, crashing Ghost instead of recovering
gracefully. Fixed by using optional chaining on config.storeConfig.

Author: muratcorlu

ghost/core/core/server/adapters/lib/redis/AdapterCacheRedis.js

@@ -16,6 +16,7 @@ class AdapterCacheRedis extends BaseCacheAdapter {
      * @param {Object} [config.cache] - caching instance compatible with cache-manager's redis store
      * @param {string} [config.host] - redis host used in case no cache instance provided
      * @param {number} [config.port] - redis port used in case no cache instance provided
+     * @param {string} [config.username] - redis username used in case no cache instance provided
      * @param {string} [config.password] - redis password used in case no cache instance provided
      * @param {Object} [config.clusterConfig] - redis cluster config used in case no cache instance provided
      * @param {Object} [config.storeConfig] - extra redis client config used in case no cache instance provided
@@ -50,7 +51,7 @@ class AdapterCacheRedis extends BaseCacheAdapter {
                 username: config.username,
                 password: config.password,
                 retryStrategy: () => {
-                    return (config.storeConfig.retryConnectSeconds || 10) * 1000;
+                    return (config.storeConfig?.retryConnectSeconds || 10) * 1000;
                 },
                 ...config.storeConfig,
                 clusterConfig: config.clusterConfig

ghost/core/test/unit/server/adapters/lib/redis/adapter-cache-redis.test.js

@@ -74,6 +74,40 @@ describe('Adapter Cache Redis', function () {
         assert.equal(cache.redisClient.options.retryStrategy, false);
     });
 
+    describe('retryStrategy', function () {
+        it('does not throw and defaults to 10 seconds when storeConfig is not provided', function () {
+            const cache = new RedisCache({
+                reuseConnection: false
+            });
+            // retryStrategy is invoked by ioredis whenever Redis becomes unavailable.
+            // It must not crash even when storeConfig is omitted from the adapter config.
+            assert.doesNotThrow(() => cache.redisClient.options.retryStrategy(1));
+            assert.equal(cache.redisClient.options.retryStrategy(1), 10000);
+            cache.redisClient.disconnect();
+        });
+
+        it('defaults to 10 seconds when retryConnectSeconds is not set in storeConfig', function () {
+            const cache = new RedisCache({
+                storeConfig: {
+                    lazyConnect: true
+                },
+                reuseConnection: false
+            });
+            assert.equal(cache.redisClient.options.retryStrategy(1), 10000);
+        });
+
+        it('uses retryConnectSeconds from storeConfig when provided', function () {
+            const cache = new RedisCache({
+                storeConfig: {
+                    lazyConnect: true,
+                    retryConnectSeconds: 5
+                },
+                reuseConnection: false
+            });
+            assert.equal(cache.redisClient.options.retryStrategy(1), 5000);
+        });
+    });
+
     describe('get', function () {
         it('can get a value from the cache', async function () {
             const cacheStub = createCacheStub();