fix: defers page view actions to allow user context to be set first (formbricks#7048)

Author: pandeymangg

packages/js-core/src/index.ts

@@ -38,6 +38,13 @@ const setup = async (setupConfig: TConfigInput): Promise<void> => {
 
   // wait for setup to complete
   await queue.wait();
+
+  // Schedule checkPageUrl to run in the next event loop iteration.
+  // This ensures that any user actions (like setUserId) called synchronously after setup()
+  // will be queued BEFORE the page view actions are processed.
+  setTimeout(() => {
+    void checkPageUrl();
+  }, 0);
 };
 
 const setUserId = async (userId: string): Promise<void> => {

packages/js-core/src/lib/common/setup.ts

@@ -6,7 +6,6 @@ import { Logger } from "@/lib/common/logger";
 import { getIsSetup, setIsSetup } from "@/lib/common/status";
 import { filterSurveys, getIsDebug, isNowExpired, wrapThrows } from "@/lib/common/utils";
 import { fetchEnvironmentState } from "@/lib/environment/state";
-import { checkPageUrl } from "@/lib/survey/no-code-action";
 import { closeSurvey } from "@/lib/survey/widget";
 import { DEFAULT_USER_STATE_NO_USER_ID } from "@/lib/user/state";
 import { sendUpdatesToBackend } from "@/lib/user/update";
@@ -320,8 +319,6 @@ export const setup = async (
   setIsSetup(true);
   logger.debug("Set up complete");
 
-  // check page url if set up after page load
-  void checkPageUrl();
   return okVoid();
 };
 

packages/js-core/src/lib/common/tests/setup.test.ts

@@ -243,7 +243,6 @@ describe("setup.ts", () => {
         },
         filteredSurveys: [{ name: "SurveyA" }],
       });
-      expect(vi.mocked(await import("@/lib/survey/no-code-action")).checkPageUrl).toHaveBeenCalled();
     });
 
     test("calls handleErrorOnFirstSetup if environment fetch fails initially", async () => {
@@ -318,11 +317,6 @@ describe("setup.ts", () => {
         await handleErrorOnFirstSetup(errorObj);
       }).rejects.toThrow("Could not set up formbricks");
 
-      // expect(AsyncStorage.setItem).toHaveBeenCalledWith(
-      //   RN_ASYNC_STORAGE_KEY,
-      //   expect.stringContaining('"value":"error"')
-      // );
-
       expect(setItemMock).toHaveBeenCalledWith(
         JS_LOCAL_STORAGE_KEY,
         expect.stringContaining('"value":"error"')

packages/js-core/src/lib/user/update-queue.ts

@@ -118,6 +118,10 @@ export class UpdateQueue {
 
             // Only send updates if we have a userId (either from updates or local storage)
             if (effectiveUserId) {
+              const previousUserId = config.get().user.data.userId;
+              const isNewUser = currentUpdates.userId && currentUpdates.userId !== previousUserId;
+              const hasAttributes = Object.keys(currentUpdates.attributes ?? {}).length > 0;
+
               const result = await sendUpdates({
                 updates: {
                   userId: effectiveUserId,
@@ -126,7 +130,13 @@ export class UpdateQueue {
               });
 
               if (result.ok) {
-                logger.debug("Updates sent successfully");
+                if (isNewUser) {
+                  logger.debug(`User successfully identified: ${effectiveUserId}`);
+                }
+                if (hasAttributes) {
+                  const attributeKeys = Object.keys(currentUpdates.attributes ?? {}).join(", ");
+                  logger.debug(`Attributes successfully set: ${attributeKeys}`);
+                }
               } else {
                 logger.error(
                   `Failed to send updates: ${result.error.responseMessage ?? result.error.message}`