Add metric reporting around the buy module (#125)

jeffyanta · web-flow · commit 4f4ec555255c · 2024-05-09T13:35:18.000-04:00
diff --git a/pkg/code/async/geyser/external_deposit.go b/pkg/code/async/geyser/external_deposit.go
@@ -30,6 +30,7 @@ import (
 	"github.com/code-payments/code-server/pkg/code/thirdparty"
 	currency_lib "github.com/code-payments/code-server/pkg/currency"
 	"github.com/code-payments/code-server/pkg/database/query"
+	"github.com/code-payments/code-server/pkg/grpc/client"
 	"github.com/code-payments/code-server/pkg/kin"
 	push_lib "github.com/code-payments/code-server/pkg/push"
 	"github.com/code-payments/code-server/pkg/retry"
@@ -635,6 +636,13 @@ func getPurchasesFromSwap(
 				}
 			}
 
+			recordBuyModulePurchaseCompletedEvent(
+				ctx,
+				client.DeviceType(onrampRecord.Platform),
+				onrampRecord.CreatedAt,
+				historyItem.BlockTime,
+			)
+
 			res = append([]*transactionpb.ExchangeDataWithoutRate{
 				{
 					Currency:     onrampRecord.Currency,
diff --git a/pkg/code/async/geyser/metrics.go b/pkg/code/async/geyser/metrics.go
@@ -4,6 +4,7 @@ import (
 	"context"
 	"time"
 
+	"github.com/code-payments/code-server/pkg/grpc/client"
 	"github.com/code-payments/code-server/pkg/metrics"
 	"github.com/code-payments/code-server/pkg/solana"
 )
@@ -20,6 +21,8 @@ const (
 	externalDepositWorkerName = "ExternalDeposit"
 	timelockStateWorkerName   = "TimelockState"
 	messagingWorkerName       = "Messaging"
+
+	buyModulePurchaseCompletedEventName = "BuyModulePurchaseCompleted"
 )
 
 func (p *service) metricsGaugeWorker(ctx context.Context) error {
@@ -135,3 +138,14 @@ func (p *service) recordBackupQueueStatusPollingEvent(ctx context.Context) {
 		"current_size": count,
 	})
 }
+
+func recordBuyModulePurchaseCompletedEvent(ctx context.Context, deviceType client.DeviceType, purchaseInitiationTime time.Time, usdcDepositTime *time.Time) {
+	kvs := map[string]interface{}{
+		"total_latency": int(time.Since(purchaseInitiationTime) / time.Millisecond),
+		"platform":      deviceType.String(),
+	}
+	if usdcDepositTime != nil {
+		kvs["swap_latency"] = int(time.Since(*usdcDepositTime) / time.Millisecond)
+	}
+	metrics.RecordEvent(ctx, buyModulePurchaseCompletedEventName, kvs)
+}
diff --git a/pkg/code/data/onramp/postgres/model.go b/pkg/code/data/onramp/postgres/model.go
@@ -20,6 +20,7 @@ type model struct {
 	Id sql.NullInt64 `db:"id"`
 
 	Owner    string    `db:"owner"`
+	Platform int       `db:"platform"`
 	Currency string    `db:"currency"`
 	Amount   float64   `db:"amount"`
 	Nonce    uuid.UUID `db:"nonce"`
@@ -34,6 +35,7 @@ func toModel(obj *onramp.Record) (*model, error) {
 
 	return &model{
 		Owner:     obj.Owner,
+		Platform:  obj.Platform,
 		Currency:  obj.Currency,
 		Amount:    obj.Amount,
 		Nonce:     obj.Nonce,
@@ -45,6 +47,7 @@ func fromModel(obj *model) *onramp.Record {
 	return &onramp.Record{
 		Id:        uint64(obj.Id.Int64),
 		Owner:     obj.Owner,
+		Platform:  obj.Platform,
 		Currency:  obj.Currency,
 		Amount:    obj.Amount,
 		Nonce:     obj.Nonce,
@@ -55,9 +58,9 @@ func fromModel(obj *model) *onramp.Record {
 func (m *model) dbPut(ctx context.Context, db *sqlx.DB) error {
 	return pgutil.ExecuteInTx(ctx, db, sql.LevelDefault, func(tx *sqlx.Tx) error {
 		query := `INSERT INTO ` + tableName + `
-			(owner, currency, amount, nonce, created_at)
-			VALUES ($1, $2, $3, $4, $5)
-			RETURNING id, owner, currency, amount, nonce, created_at`
+			(owner, platform, currency, amount, nonce, created_at)
+			VALUES ($1, $2, $3, $4, $5, $6)
+			RETURNING id, owner, platform, currency, amount, nonce, created_at`
 
 		if m.CreatedAt.IsZero() {
 			m.CreatedAt = time.Now()
@@ -67,6 +70,7 @@ func (m *model) dbPut(ctx context.Context, db *sqlx.DB) error {
 			ctx,
 			query,
 			m.Owner,
+			m.Platform,
 			m.Currency,
 			m.Amount,
 			m.Nonce,
@@ -81,7 +85,7 @@ func dbGet(ctx context.Context, db *sqlx.DB, nonce uuid.UUID) (*model, error) {
 	res := &model{}
 
 	query := `SELECT
-		id, owner, currency, amount, nonce, created_at
+		id, owner, platform, currency, amount, nonce, created_at
 		FROM ` + tableName + `
 		WHERE nonce = $1
 		LIMIT 1`
diff --git a/pkg/code/data/onramp/postgres/store_test.go b/pkg/code/data/onramp/postgres/store_test.go
@@ -28,6 +28,7 @@ const (
 			id SERIAL NOT NULL PRIMARY KEY,
 
 			owner TEXT NOT NULL,
+			platform INTEGER NOT NULL,
 			currency TEXT NOT NULL,
 			amount numeric(18, 9) NOT NULL,
 			nonce UUID NOT NULL,
diff --git a/pkg/code/data/onramp/purchase.go b/pkg/code/data/onramp/purchase.go
@@ -13,6 +13,7 @@ type Record struct {
 	Id uint64
 
 	Owner    string
+	Platform int // todo: can't use client.DeviceType due to import cycle
 	Currency string
 	Amount   float64
 	Nonce    uuid.UUID
@@ -45,6 +46,7 @@ func (r *Record) Clone() Record {
 		Id: r.Id,
 
 		Owner:    r.Owner,
+		Platform: r.Platform,
 		Currency: r.Currency,
 		Amount:   r.Amount,
 		Nonce:    r.Nonce,
@@ -57,6 +59,7 @@ func (r *Record) CopyTo(dst *Record) {
 	dst.Id = r.Id
 
 	dst.Owner = r.Owner
+	dst.Platform = r.Platform
 	dst.Currency = r.Currency
 	dst.Amount = r.Amount
 	dst.Nonce = r.Nonce
diff --git a/pkg/code/data/onramp/tests/tests.go b/pkg/code/data/onramp/tests/tests.go
@@ -10,6 +10,7 @@ import (
 	"github.com/stretchr/testify/require"
 
 	"github.com/code-payments/code-server/pkg/code/data/onramp"
+	"github.com/code-payments/code-server/pkg/grpc/client"
 )
 
 func RunTests(t *testing.T, s onramp.Store, teardown func()) {
@@ -34,6 +35,7 @@ func testHappyPath(t *testing.T, s onramp.Store) {
 
 		expected := &onramp.Record{
 			Owner:    "owner",
+			Platform: int(client.DeviceTypeIOS),
 			Currency: "cad",
 			Amount:   50.01,
 			Nonce:    nonce,
@@ -58,6 +60,7 @@ func testHappyPath(t *testing.T, s onramp.Store) {
 
 func assertEquivalentRecords(t *testing.T, obj1, obj2 *onramp.Record) {
 	assert.Equal(t, obj1.Owner, obj2.Owner)
+	assert.Equal(t, obj1.Platform, obj2.Platform)
 	assert.Equal(t, obj1.Currency, obj2.Currency)
 	assert.Equal(t, obj1.Amount, obj2.Amount)
 	assert.Equal(t, obj1.Nonce, obj2.Nonce)
diff --git a/pkg/code/server/grpc/transaction/v2/metrics.go b/pkg/code/server/grpc/transaction/v2/metrics.go
@@ -4,16 +4,19 @@ import (
 	"context"
 	"time"
 
-	"github.com/code-payments/code-server/pkg/metrics"
 	"github.com/code-payments/code-server/pkg/code/common"
 	"github.com/code-payments/code-server/pkg/code/data/intent"
+	currency_lib "github.com/code-payments/code-server/pkg/currency"
+	"github.com/code-payments/code-server/pkg/grpc/client"
+	"github.com/code-payments/code-server/pkg/metrics"
 )
 
 const (
 	userIntentCreatedEventName            = "UserIntentCreated"
 	privateUpgradeEventName               = "PrivateTransferUpgraded"
 	submitIntentLatencyBreakdownEventName = "SubmitIntentLatencyBreakdown"
 	airdropEventName                      = "Airdrop"
+	buyModulePurchaseInitiatedEventName   = "BuyModulePurchaseInitiated"
 )
 
 func recordUserIntentCreatedEvent(ctx context.Context, intentRecord *intent.Record) {
@@ -49,3 +52,11 @@ func recordAirdropEvent(ctx context.Context, owner *common.Account, airdropType
 		"usd_value":    usdValue,
 	})
 }
+
+func recordBuyModulePurchaseInitiatedEvent(ctx context.Context, currency currency_lib.Code, amount float64, deviceType client.DeviceType) {
+	metrics.RecordEvent(ctx, buyModulePurchaseInitiatedEventName, map[string]interface{}{
+		"currency": string(currency),
+		"amount":   amount,
+		"platform": deviceType.String(),
+	})
+}
diff --git a/pkg/code/server/grpc/transaction/v2/onramp.go b/pkg/code/server/grpc/transaction/v2/onramp.go
@@ -23,6 +23,14 @@ func (s *transactionServer) DeclareFiatOnrampPurchaseAttempt(ctx context.Context
 	log := s.log.WithField("method", "DeclareFiatOnrampPurchaseAttempt")
 	log = client.InjectLoggingMetadata(ctx, log)
 
+	var deviceType client.DeviceType
+	userAgent, err := client.GetUserAgent(ctx)
+	if err == nil {
+		deviceType = userAgent.DeviceType
+	} else {
+		deviceType = client.DeviceTypeUnknown
+	}
+
 	owner, err := common.NewAccountFromProto(req.Owner)
 	if err != nil {
 		log.WithError(err).Warn("invalid owner account")
@@ -73,6 +81,7 @@ func (s *transactionServer) DeclareFiatOnrampPurchaseAttempt(ctx context.Context
 
 	record := &onramp.Record{
 		Owner:     owner.PublicKey().ToBase58(),
+		Platform:  int(deviceType),
 		Currency:  string(currency),
 		Amount:    amount,
 		Nonce:     nonce,
@@ -84,6 +93,13 @@ func (s *transactionServer) DeclareFiatOnrampPurchaseAttempt(ctx context.Context
 		return nil, status.Error(codes.Internal, "")
 	}
 
+	recordBuyModulePurchaseInitiatedEvent(
+		ctx,
+		currency,
+		amount,
+		deviceType,
+	)
+
 	return &transactionpb.DeclareFiatOnrampPurchaseAttemptResponse{
 		Result: transactionpb.DeclareFiatOnrampPurchaseAttemptResponse_OK,
 	}, nil
