Skip to content

Commit 213d06d

Browse files
authored
Update micropayment limit to $5 maximum (#83)
1 parent 1c67bd6 commit 213d06d

File tree

4 files changed

+19
-8
lines changed

4 files changed

+19
-8
lines changed

pkg/code/limit/limits.go

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,17 @@ type MicroPaymentLimit struct {
1414
Max float64
1515
}
1616

17+
func init() {
18+
newMicroPaymentLimits := make(map[currency_lib.Code]MicroPaymentLimit)
19+
for currency, limit := range MicroPaymentLimits {
20+
newMicroPaymentLimits[currency] = MicroPaymentLimit{
21+
Min: limit.Min,
22+
Max: 5.0 * limit.Max,
23+
}
24+
}
25+
MicroPaymentLimits = newMicroPaymentLimits
26+
}
27+
1728
// todo: Better way of managing all of this
1829
var (
1930
SendLimits = map[currency_lib.Code]SendLimit{
@@ -259,7 +270,7 @@ var (
259270
"kes": {Min: 5.00, Max: 100.00},
260271
"kgs": {Min: 2.00, Max: 40.00},
261272
"khr": {Min: 200.00, Max: 4000.00},
262-
"kin": {Min: 5000.00, Max: 100000.00},
273+
"kin": {Min: 2500.00, Max: 50000.00},
263274
"kmf": {Min: 20.00, Max: 400.00},
264275
"kpw": {Min: 50.00, Max: 1000.00},
265276
"krw": {Min: 50.00, Max: 1000.00},

pkg/code/server/grpc/messaging/server_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -437,7 +437,7 @@ func TestSendMessage_RequestToReceiveBill_KinValue_Validation(t *testing.T) {
437437
sendMessageCall = env.client1.sendRequestToReceiveKinBillMessage(t, rendezvousKey, &testRequestToReceiveBillConf{
438438
disableDomainVerification: true,
439439
})
440-
sendMessageCall.assertInvalidMessageError(t, "kin currency has a minimum amount of 5000.00")
440+
sendMessageCall.assertInvalidMessageError(t, "kin currency has a minimum amount of 2500.00")
441441
env.server1.assertNoMessages(t, rendezvousKey)
442442
env.server1.assertRequestRecordNotSaved(t, rendezvousKey)
443443

@@ -446,7 +446,7 @@ func TestSendMessage_RequestToReceiveBill_KinValue_Validation(t *testing.T) {
446446
sendMessageCall = env.client1.sendRequestToReceiveKinBillMessage(t, rendezvousKey, &testRequestToReceiveBillConf{
447447
disableDomainVerification: true,
448448
})
449-
sendMessageCall.assertInvalidMessageError(t, "kin currency has a maximum amount of 100000.00")
449+
sendMessageCall.assertInvalidMessageError(t, "kin currency has a maximum amount of 250000.00")
450450
env.server1.assertNoMessages(t, rendezvousKey)
451451
env.server1.assertRequestRecordNotSaved(t, rendezvousKey)
452452

@@ -625,7 +625,7 @@ func TestSendMessage_RequestToReceiveBill_FiatValue_Validation(t *testing.T) {
625625
sendMessageCall = env.client1.sendRequestToReceiveFiatBillMessage(t, rendezvousKey, &testRequestToReceiveBillConf{
626626
disableDomainVerification: true,
627627
})
628-
sendMessageCall.assertInvalidMessageError(t, "usd currency has a maximum amount of 1.00")
628+
sendMessageCall.assertInvalidMessageError(t, "usd currency has a maximum amount of 5.00")
629629
env.server1.assertNoMessages(t, rendezvousKey)
630630
env.server1.assertRequestRecordNotSaved(t, rendezvousKey)
631631

pkg/code/server/grpc/messaging/testutil.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -658,8 +658,8 @@ func (c *clientEnv) sendRequestToReceiveKinBillMessage(
658658
exchangeData.Quarks = kin.ToQuarks(1)
659659
}
660660
if c.conf.simulateLargeNativeAmount {
661-
exchangeData.NativeAmount = 100_001
662-
exchangeData.Quarks = kin.ToQuarks(100_001)
661+
exchangeData.NativeAmount = 250_001
662+
exchangeData.Quarks = kin.ToQuarks(250_001)
663663
}
664664
if c.conf.simulateFractionalNativeAmount {
665665
exchangeData.NativeAmount += 0.1
@@ -843,7 +843,7 @@ func (c *clientEnv) sendRequestToReceiveFiatBillMessage(
843843
exchangeData.NativeAmount = 0.01
844844
}
845845
if c.conf.simulateLargeNativeAmount {
846-
exchangeData.NativeAmount = 1.01
846+
exchangeData.NativeAmount = 5.01
847847
}
848848

849849
additionalFees := []*transactionpb.AdditionalFeePayment{

pkg/code/server/grpc/micropayment/server_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -497,7 +497,7 @@ func TestCodify_AmountValidation(t *testing.T) {
497497
}
498498
require.NoError(t, env.data.CreateAccountInfo(env.ctx, accountInfoRecord))
499499

500-
for _, amount := range []float64{0.01, 1.01} {
500+
for _, amount := range []float64{0.01, 5.01} {
501501
codifyReq := &micropaymentpb.CodifyRequest{
502502
OwnerAccount: owner.ToProto(),
503503
PrimaryAccount: destination.ToProto(),

0 commit comments

Comments
 (0)