Add auto-reply to Twitter registration tweets (#174)

Author: jeffyanta

go.mod

@@ -65,6 +65,7 @@ require (
 	github.com/coreos/go-semver v0.3.0 // indirect
 	github.com/coreos/go-systemd/v22 v22.3.2 // indirect
 	github.com/davecgh/go-spew v1.1.1 // indirect
+	github.com/dghubble/oauth1 v0.7.3 // indirect
 	github.com/docker/cli v20.10.7+incompatible // indirect
 	github.com/docker/docker v20.10.7+incompatible // indirect
 	github.com/docker/go-connections v0.4.0 // indirect

go.sum

@@ -141,6 +141,8 @@ github.com/creack/pty v1.1.11/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
+github.com/dghubble/oauth1 v0.7.3 h1:EkEM/zMDMp3zOsX2DC/ZQ2vnEX3ELK0/l9kb+vs4ptE=
+github.com/dghubble/oauth1 v0.7.3/go.mod h1:oxTe+az9NSMIucDPDCCtzJGsPhciJV33xocHfcR2sVY=
 github.com/dgrijalva/jwt-go v3.2.0+incompatible/go.mod h1:E3ru+11k8xSBh+hMPgOLZmtrrCbhqsmaPHjLKYnJCaQ=
 github.com/dgryski/go-sip13 v0.0.0-20181026042036-e10d5fee7954/go.mod h1:vAd38F8PWV+bWy6jNmig1y/TA+kYO4g3RSRF0IAv0no=
 github.com/docker/cli v20.10.7+incompatible h1:pv/3NqibQKphWZiAskMzdz8w0PRbtTaEB+f6NwdU7Is=

pkg/code/async/user/twitter.go

@@ -4,13 +4,15 @@ import (
 	"context"
 	"crypto/ed25519"
 	"database/sql"
+	"fmt"
 	"strings"
 	"time"
 
 	"github.com/google/uuid"
 	"github.com/mr-tron/base58"
 	"github.com/newrelic/go-agent/v3/newrelic"
 	"github.com/pkg/errors"
+	"github.com/sirupsen/logrus"
 
 	commonpb "github.com/code-payments/code-protobuf-api/generated/go/common/v1"
 	userpb "github.com/code-payments/code-protobuf-api/generated/go/user/v1"
@@ -103,6 +105,8 @@ func (p *service) twitterUserInfoUpdateWorker(serviceCtx context.Context, interv
 }
 
 func (p *service) processNewTwitterRegistrations(ctx context.Context) error {
+	log := p.log.WithField("method", "processNewTwitterRegistrations")
+
 	tweets, err := p.findNewRegistrationTweets(ctx)
 	if err != nil {
 		return errors.Wrap(err, "error finding new registration tweets")
@@ -113,6 +117,11 @@ func (p *service) processNewTwitterRegistrations(ctx context.Context) error {
 			return errors.Errorf("author missing in tweet %s", tweet.ID)
 		}
 
+		log := log.WithFields(logrus.Fields{
+			"tweet":    tweet.ID,
+			"username": tweet.AdditionalMetadata.Author,
+		})
+
 		// Attempt to find a verified tip account from the registration tweet
 		tipAccount, registrationNonce, err := p.findVerifiedTipAccountRegisteredInTweet(ctx, tweet)
 		switch err {
@@ -140,7 +149,21 @@ func (p *service) processNewTwitterRegistrations(ctx context.Context) error {
 
 		switch err {
 		case nil:
-			go push_util.SendTwitterAccountConnectedPushNotification(ctx, p.data, p.pusher, tipAccount)
+			// todo: all of these success handlers are fire and forget best-effort delivery
+
+			go func() {
+				err := push_util.SendTwitterAccountConnectedPushNotification(ctx, p.data, p.pusher, tipAccount)
+				if err != nil {
+					log.WithError(err).Warn("failure sending success push")
+				}
+			}()
+
+			go func() {
+				err := p.sendRegistrationSuccessReply(ctx, tweet.ID, tweet.AdditionalMetadata.Author.Username)
+				if err != nil {
+					log.WithError(err).Warn("failure sending success reply")
+				}
+			}()
 		case twitter.ErrDuplicateTipAddress:
 			err = p.data.ExecuteInTx(ctx, sql.LevelDefault, func(ctx context.Context) error {
 				err = p.data.MarkTwitterNonceAsUsed(ctx, tweet.ID, *registrationNonce)
@@ -228,25 +251,6 @@ func (p *service) updateCachedTwitterUser(ctx context.Context, user *twitter_lib
 	}
 }
 
-func (p *service) onTwitterUsernameNotFound(ctx context.Context, username string) error {
-	record, err := p.data.GetTwitterUserByUsername(ctx, username)
-	switch err {
-	case nil:
-	case twitter.ErrUserNotFound:
-		return nil
-	default:
-		return errors.Wrap(err, "error getting cached twitter user")
-	}
-
-	record.LastUpdatedAt = time.Now()
-
-	err = p.data.SaveTwitterUser(ctx, record)
-	if err != nil {
-		return errors.Wrap(err, "error updating cached twitter user")
-	}
-	return nil
-}
-
 func (p *service) findNewRegistrationTweets(ctx context.Context) ([]*twitter_lib.Tweet, error) {
 	var pageToken *string
 	var res []*twitter_lib.Tweet
@@ -361,6 +365,36 @@ func (p *service) findVerifiedTipAccountRegisteredInTweet(ctx context.Context, t
 	return nil, nil, errTwitterRegistrationNotFound
 }
 
+func (p *service) sendRegistrationSuccessReply(ctx context.Context, regristrationTweetId, username string) error {
+	// todo: localize this
+	message := fmt.Sprintf(
+		"@%s your X account is now connected! Share this link to receive tips: https://tipcard.getcode.com/x/%s",
+		username,
+		username,
+	)
+	_, err := p.twitterClient.SendReply(ctx, regristrationTweetId, message)
+	return err
+}
+
+func (p *service) onTwitterUsernameNotFound(ctx context.Context, username string) error {
+	record, err := p.data.GetTwitterUserByUsername(ctx, username)
+	switch err {
+	case nil:
+	case twitter.ErrUserNotFound:
+		return nil
+	default:
+		return errors.Wrap(err, "error getting cached twitter user")
+	}
+
+	record.LastUpdatedAt = time.Now()
+
+	err = p.data.SaveTwitterUser(ctx, record)
+	if err != nil {
+		return errors.Wrap(err, "error updating cached twitter user")
+	}
+	return nil
+}
+
 func toProtoVerifiedType(value string) userpb.TwitterUser_VerifiedType {
 	switch value {
 	case "blue":

pkg/twitter/client.go

@@ -12,6 +12,7 @@ import (
 	"sync"
 	"time"
 
+	"github.com/dghubble/oauth1"
 	"github.com/pkg/errors"
 
 	"github.com/code-payments/code-server/pkg/metrics"
@@ -28,20 +29,24 @@ const (
 type Client struct {
 	httpClient *http.Client
 
-	clientId     string
-	clientSecret string
+	clientId          string
+	clientSecret      string
+	accessToken       string
+	accessTokenSecret string
 
 	bearerTokenMu          sync.RWMutex
 	bearerToken            string
 	lastBearerTokenRefresh time.Time
 }
 
 // NewClient returns a new Twitter client
-func NewClient(clientId, clientSecret string) *Client {
+func NewClient(clientId, clientSecret, accessToken, accessTokenSecret string) *Client {
 	return &Client{
-		httpClient:   http.DefaultClient,
-		clientId:     clientId,
-		clientSecret: clientSecret,
+		httpClient:        http.DefaultClient,
+		clientId:          clientId,
+		clientSecret:      clientSecret,
+		accessToken:       accessToken,
+		accessTokenSecret: accessTokenSecret,
 	}
 }
 
@@ -143,8 +148,16 @@ func (c *Client) SearchRecentTweets(ctx context.Context, searchString string, ma
 	return tweets, nextToken, err
 }
 
+// SendReply sends a reply to the provided tweet
+func (c *Client) SendReply(ctx context.Context, tweetId, text string) (string, error) {
+	tracer := metrics.TraceMethodCall(ctx, metricsStructName, "SendReply")
+	defer tracer.End()
+
+	return c.sendTweet(ctx, text, &tweetId)
+}
+
 func (c *Client) getUser(ctx context.Context, fromUrl string) (*User, error) {
-	bearerToken, err := c.getBearerToken(c.clientId, c.clientSecret)
+	bearerToken, err := c.getBearerToken()
 	if err != nil {
 		return nil, err
 	}
@@ -189,7 +202,7 @@ func (c *Client) getUser(ctx context.Context, fromUrl string) (*User, error) {
 }
 
 func (c *Client) getTweets(ctx context.Context, fromUrl string) ([]*Tweet, *string, error) {
-	bearerToken, err := c.getBearerToken(c.clientId, c.clientSecret)
+	bearerToken, err := c.getBearerToken()
 	if err != nil {
 		return nil, nil, err
 	}
@@ -253,7 +266,77 @@ func (c *Client) getTweets(ctx context.Context, fromUrl string) ([]*Tweet, *stri
 	return result.Data, result.Meta.NextToken, nil
 }
 
-func (c *Client) getBearerToken(clientId, clientSecret string) (string, error) {
+func (c *Client) sendTweet(ctx context.Context, text string, inReplyTo *string) (string, error) {
+	apiUrl := baseUrl + "tweets"
+
+	type ReplyParams struct {
+		InReplyToTweetId string `json:"in_reply_to_tweet_id"`
+	}
+	type Request struct {
+		Text  string       `json:"text"`
+		Reply *ReplyParams `json:"reply"`
+	}
+
+	reqPayload := Request{
+		Text: text,
+	}
+	if inReplyTo != nil {
+		reqPayload.Reply = &ReplyParams{
+			InReplyToTweetId: *inReplyTo,
+		}
+	}
+
+	reqJson, err := json.Marshal(reqPayload)
+	if err != nil {
+		return "", err
+	}
+
+	req, err := http.NewRequest("POST", apiUrl, bytes.NewBuffer(reqJson))
+	if err != nil {
+		return "", err
+	}
+
+	req = req.WithContext(ctx)
+
+	req.Header.Set("Content-Type", "application/json")
+
+	config := oauth1.NewConfig(c.clientId, c.clientSecret)
+	token := oauth1.NewToken(c.accessToken, c.accessTokenSecret)
+	httpClient := config.Client(oauth1.NoContext, token)
+
+	resp, err := httpClient.Do(req)
+	if err != nil {
+		return "", err
+	}
+	defer resp.Body.Close()
+
+	if resp.StatusCode != http.StatusCreated {
+		return "", fmt.Errorf("unexpected http status code: %d", resp.StatusCode)
+	}
+
+	var result struct {
+		Data struct {
+			Id *string `json:"id"`
+		} `json:"data"`
+		Errors []*twitterError `json:"errors"`
+	}
+
+	body, err := io.ReadAll(resp.Body)
+	if err != nil {
+		return "", err
+	}
+
+	if err := json.Unmarshal(body, &result); err != nil {
+		return "", err
+	}
+
+	if len(result.Errors) > 0 {
+		return "", result.Errors[0].toError()
+	}
+	return *result.Data.Id, nil
+}
+
+func (c *Client) getBearerToken() (string, error) {
 	c.bearerTokenMu.RLock()
 	if time.Since(c.lastBearerTokenRefresh) < bearerTokenMaxAge {
 		c.bearerTokenMu.RUnlock()
@@ -275,7 +358,7 @@ func (c *Client) getBearerToken(clientId, clientSecret string) (string, error) {
 	}
 
 	req.Header.Add("Content-Type", "application/x-www-form-urlencoded")
-	req.SetBasicAuth(clientId, clientSecret)
+	req.SetBasicAuth(c.clientId, c.clientSecret)
 
 	resp, err := c.httpClient.Do(req)
 	if err != nil {